feat: #1218 address confusing structure in web components #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ant066,
nphivu414,
phmngocnghia,
duong-se,
trankhacvy and
willmcvay
vuhuucuong
force-pushed
the
feat/1218-address-confusing-structure-in-web-components
branch
from
a7871fd to
c3d6114
Compare
phmngocnghia
approved these changes
May 20, 2020
| "release:server:prod": "node ../../scripts/release/release-serverless.js web-components", | ||
| "release:npm:prod": "node ../../scripts/release/release-npm.js elements --skip-edit-release-note", | ||
| "release:npm:prod": "node ../../scripts/release/release-npm.js web-components --skip-edit-release-note", |
There was a problem hiding this comment.
@willmcvay I think this will solve deployment issue of web-component release prod pipeline... Seems like typos in my previous commit in this file. That's great @vuhuucuong, if release:npm:prod works ok this time, please help me comment on ticket: #1107
There was a problem hiding this comment.
@phmngocnghia got you 👍
vuhuucuong
deleted the
feat/1218-address-confusing-structure-in-web-components
branch
This was referenced Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #1218
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1218
What is the new behavior?
scriptsfolders out of./srcappointment-plannerinto a separated folder/serverfolder, andserverless.ymlinside that folderDoes this introduce a breaking change?
Other information
NOTE
We will need to deploy the new server for
search-widgetwith nameweb-components.search-widgetbehind this API Gateway to replace the old one, because the oldsearch-widgetserver is namedweb-components(see here)But it's actually just
search-widgetserver, to avoid confusing, and to be able to deploy otherweb-componentsserver laterAfter deploy, need to update
config.jsontoo