Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address confusing structure in web components #1218

Closed
willmcvay opened this issue May 12, 2020 · 4 comments · Fixed by #1305, #1307 or #1353
Closed

Address confusing structure in web components #1218

willmcvay opened this issue May 12, 2020 · 4 comments · Fixed by #1305, #1307 or #1353
Assignees
Labels
chore Maintenance or housekeeping tasks demo-site front-end Relates to front end issues web-components

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

_The current structure of web components does not make sense regarding the widgets it should output

The web components should output 5 named packages, plus common folder:

  • Search Widget
  • Book Valuation Widget
  • Book Viewing Widget
  • Property Detail Widget
  • Appointment Planner Component

Each of the four widgets should have it's own script on the CDN and be an exportable module from NPM.

The Appointment Planner should be a sub component of both book a valuation and book a viewing and live in it's own folder as it is shared. The appointment planner should not need to be rendered separately or deployed as a separate script, rather it should be included in the booking components at compile time.

Each of the 4 widgets plus the appointment planner will have their own server folder, lambda and API like search widget.

Task is to ensure this structure works, change naming conventions where required, deploy and update the demo site_

@willmcvay willmcvay added chore Maintenance or housekeeping tasks demo-site web-components front-end Relates to front end issues labels May 12, 2020
@vuhuucuong vuhuucuong self-assigned this May 19, 2020
vuhuucuong pushed a commit that referenced this issue May 19, 2020
vuhuucuong pushed a commit that referenced this issue May 20, 2020
vuhuucuong pushed a commit that referenced this issue May 20, 2020
vuhuucuong pushed a commit that referenced this issue May 20, 2020
vuhuucuong pushed a commit that referenced this issue May 20, 2020
vuhuucuong pushed a commit that referenced this issue May 20, 2020
vuhuucuong pushed a commit that referenced this issue May 21, 2020
vuhuucuong pushed a commit that referenced this issue May 21, 2020
* feat:#1218 moving folders

* feat:#1218 moving planner to separated folder

* feat:#1218 tweak serverless.yml

* feat: #1218 finish serverless, update tests

* feat: #1218 check server exist before start
vuhuucuong pushed a commit that referenced this issue May 21, 2020
@willmcvay
Copy link
Contributor Author

Screenshot 2020-05-26 at 14 20 55

The folder structure still doesn't quite map right, as per the spec, the widgets are;

Search Widget
Book Valuation Widget
Book Viewing Widget
Property Detail Widget
Appointment Planner Component

So I guess a clear folder structure would be:

search-widget
book-valuation-widget
book-viewing-widget
property-detail-widget
appointment-planner-component

@willmcvay willmcvay reopened this May 26, 2020
@vuhuucuong
Copy link
Contributor

hi @willmcvay, do we need to put common folder in ./src, or move it outside, and about the login folder, should it be in here ?

@willmcvay
Copy link
Contributor Author

Login, yes, but should be called login-reapit-component common is fine where it is I think

@vuhuucuong
Copy link
Contributor

@willmcvay Thank you, I will fix it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment