Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

reapit / foundations Public

Notifications You must be signed in to change notification settings
Fork 22
Star 56

Code
Issues 702
Pull requests 4
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1210 #1026 ui for developer/client side standalone #1304

Merged

phmngocnghia merged 8 commits into master from feat-#1210-ui-for-developer-side-standalone

May 22, 2020

Merged

feat: #1210 #1026 ui for developer/client side standalone #1304

phmngocnghia merged 8 commits into master from feat-#1210-ui-for-developer-side-standalone

May 22, 2020

Conversation 19 Commits 8 Checks 0 Files changed

Conversation

Copy link

Contributor

phmngocnghia commented May 20, 2020 •

edited

Loading

Pull request checklist

Does this close any currently open issues?

fixes: #1210 #1206

Please check if your PR fulfills the following requirements:

Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)
Build (yarn build) was run locally and any changes were pushed
Lint (yarn lint) has passed locally and any fixes were made for failures
Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

Bugfix
Feature
Code style update (formatting, renaming)
Refactoring (no functional changes, no api changes)
Build related changes
Documentation content changes
Other (please describe):

What is the current behavior?

Goto: https://dev.marketplace.reapit.cloud/developer/apps/1161242a-f650-4d1d-aed7-909853fe7ee1 - current developer detail app page
Goto: http://localhost:8080/client/apps/5c0ce6b1-0573-4594-9606-adb55671d8b8 - current client developer detail app page, switch

Issue Number: #1210 #1206

What is the new behavior?

Start app in LOCAL mode
Goto: http://localhost:8080/developer/apps/1161242a-f650-4d1d-aed7-909853fe7ee1

Does this introduce a breaking change?

Yes
No

Other information

Update lot of stuff on developer-detail-app page

Sorry, something went wrong.

All reactions


          feat: #1210 ui for developer side standalone

c0040a4

github-actions bot requested review from ant066, nphivu414, duong-se, trankhacvy, vuhuucuong and willmcvay

May 20, 2020 13:35

github-actions bot assigned phmngocnghia

github-actions bot added the marketplace Relates to the Marketplace label

phmngocnghia changed the title ~~feat: #1210 ui for developer side standalone~~ [WIP]feat: #1210 ui for developer side standalone

github-actions bot closed this

github-actions bot reviewed

View reviewed changes

Copy link

Contributor

github-actions bot left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.* pattern. Please fix the title and re-open the pull request.

Sorry, something went wrong.

All reactions

phmngocnghia reopened this

phmngocnghia changed the title ~~[WIP]feat: #1210 ui for developer side standalone~~ feat: #1210 ui for developer side standalone

phmngocnghia closed this

phmngocnghia reopened this

github-actions bot reviewed

View reviewed changes

Copy link

Contributor

github-actions bot left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.* pattern. Please fix the title and re-open the pull request.

Sorry, something went wrong.

All reactions

github-actions bot reviewed

View reviewed changes

Copy link

Contributor

github-actions bot left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.* pattern. Please fix the title and re-open the pull request.

Sorry, something went wrong.

All reactions

github-actions bot closed this

github-actions bot closed this

phmngocnghia reopened this

duong-se reviewed

View reviewed changes

packages/marketplace/src/components/pages/developer-app-detail/__test__/aside.test.tsx Outdated Show resolved Hide resolved

duong-se reviewed

View reviewed changes

packages/marketplace/src/components/pages/developer-app-detail/__test__/aside.test.tsx Outdated Show resolved Hide resolved

duong-se reviewed

View reviewed changes

...rketplace/src/components/pages/developer-app-detail/app-detail/__test__/app-content.test.tsx Show resolved Hide resolved

phmngocnghia force-pushed the feat-#1210-ui-for-developer-side-standalone branch from aa31452 to eedf991 Compare

May 20, 2020 15:40

github-actions bot requested a review from duong-se

May 20, 2020 15:41


          feat: #1210: remove unused files

eedf991

duong-se reviewed

View reviewed changes

...marketplace/src/components/pages/developer-app-detail/app-detail/app-content/app-content.tsx Outdated Show resolved Hide resolved

duong-se reviewed

View reviewed changes

packages/marketplace/src/components/pages/developer-app-detail/aside.tsx Outdated Show resolved Hide resolved

duong-se reviewed

View reviewed changes

packages/marketplace/src/utils/route-dispatcher.ts Outdated Show resolved Hide resolved

github-actions bot requested a review from duong-se

May 20, 2020 16:24


          feat #1210: fix review comments

e509fc1

duong-se reviewed

View reviewed changes

...marketplace/src/components/pages/developer-app-detail/app-detail/app-content/app-content.tsx Outdated Show resolved Hide resolved

duong-se reviewed

View reviewed changes

packages/marketplace/src/components/pages/developer-app-detail/aside.tsx Outdated Show resolved Hide resolved

duong-se reviewed

View reviewed changes

packages/marketplace/src/components/pages/developer-app-detail/aside.tsx Outdated Show resolved Hide resolved

github-actions bot requested a review from duong-se

May 21, 2020 03:10

phmngocnghia force-pushed the feat-#1210-ui-for-developer-side-standalone branch from b04d4de to 8419d7f Compare

May 21, 2020 03:21


          unmount invisible modal

8419d7f

nphivu414 suggested changes

View reviewed changes

...marketplace/src/components/pages/developer-app-detail/app-detail/app-content/app-content.tsx Outdated Show resolved Hide resolved

packages/marketplace/src/components/ui/app-revision-comparision/app-revision-comparision.tsx Show resolved Hide resolved

...marketplace/src/components/pages/developer-app-detail/app-detail/app-content/app-content.tsx Show resolved Hide resolved

duong-se approved these changes

View reviewed changes

Copy link

Contributor

duong-se left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see @nphivu414 comment. Others LGTM

Sorry, something went wrong.

All reactions

github-actions bot requested review from nphivu414 and duong-se

May 21, 2020 05:55

undefined added 2 commits

May 21, 2020 12:55


          feat #1210: update type definition HandleUninstallSuccessParams

1167b4e


          feat #1210: move app-header into reuseable folder

e986179

phmngocnghia changed the title ~~feat: #1210 ui for developer side standalone~~ feat: #1210 #1026 ui for developer/client side standalone


          feat: 1206: UI for the client-side standalone App

20287ab

willmcvay approved these changes

View reviewed changes

Copy link

Contributor

willmcvay left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sorry, something went wrong.

All reactions

github-actions bot requested a review from willmcvay

May 21, 2020 12:41


          fix #1225: update mobile developer app detail mobile based on new req…

2f6914d

…uest

nphivu414 approved these changes

View reviewed changes

phmngocnghia merged commit a7122b9 into master

phmngocnghia deleted the feat-#1210-ui-for-developer-side-standalone branch

May 22, 2020 03:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

nphivu414 nphivu414 approved these changes

ant066 Awaiting requested review from ant066

trankhacvy Awaiting requested review from trankhacvy

vuhuucuong Awaiting requested review from vuhuucuong

duong-se Awaiting requested review from duong-se

willmcvay Awaiting requested review from willmcvay

Assignees

Labels

Relates to the Marketplace

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI for the Developer Side standalone app

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.