unmount invisible modal

reapit · May 21, 2020 · b04d4de · b04d4de
1 parent e509fc1
commit b04d4de
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 19 deletions.
diff --git a/...ts/pages/developer-app-detail/app-detail/__test__/__snapshots__/app-content.test.tsx.snap b/...ts/pages/developer-app-detail/app-detail/__test__/__snapshots__/app-content.test.tsx.snap
@@ -62,9 +62,6 @@ exports[`AppContent AppContent - should match snapshoot 1`] = `
     }
   >
     <div>
-      <Component
-        visible={false}
-      />
       <div />
       <div>
         <Component

diff --git a/...ketplace/src/components/pages/developer-app-detail/app-detail/app-content/app-content.tsx b/...ketplace/src/components/pages/developer-app-detail/app-detail/app-content/app-content.tsx
@@ -94,22 +94,23 @@ const AppContent: React.FC<AppContentProps> = ({ appDetailData }) => {
 
   return (
     <div className={clientAppDetailStyles.appContentContainer}>
-      <Modal visible={isVisibleUninstallModal}>
-        <ConfirmUninstall
-          isSetAppDetailStaleAfterUninstallSuccess={false}
-          appName={name}
-          installationDetail={uninstallApp}
-          afterClose={handleAfterClose({ setUninstallApp })}
-          onUninstallSuccess={handleUninstallSuccess({
-            handleAfterClose,
-            setUninstallApp,
-            developerId,
-            appId: id,
-            dispatch,
-          })}
-        />
-      </Modal>
-
+      {isVisibleUninstallModal && (
+        <Modal visible={isVisibleUninstallModal}>
+          <ConfirmUninstall
+            isSetAppDetailStaleAfterUninstallSuccess={false}
+            appName={name}
+            installationDetail={uninstallApp}
+            afterClose={handleAfterClose({ setUninstallApp })}
+            onUninstallSuccess={handleUninstallSuccess({
+              handleAfterClose,
+              setUninstallApp,
+              developerId,
+              appId: id,
+              dispatch,
+            })}
+          />
+        </Modal>
+      )}
       <div className={clientAppDetailStyles.gutter}>{summary}</div>
       <div className={appDetailStyles.gutter}>
         <H5 className="flex items-center">
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       >
         <div>
-          <Component
-            visible={false}
-          />
           <div />
           <div>
             <Component
@@ Expand Down @@