refactor: #10935 seperate node scripts from fe #11037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
connect-session
dependencies
payments-service
seed-data-workflow
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bashleigh
changed the title
bashleigh
force-pushed
the
refactor/#10935-seperate-node-scripts-from-fe
branch
from
90ea580 to
397f8dc
Compare
willmcvay
reviewed
Apr 17, 2024
|
|
||
| export default defineConfig({ | ||
| entry: ['src/index.ts'], | ||
| target: 'node16', |
There was a problem hiding this comment.
Node 18 right? Think 16 is out of support
| As per the browser usage, you will need to instantiate the class with your initializers, in this case connectClientId, connectOAuthUrl (in the same way as the browser module), but with the addition of the connectClientSecret you obtain from your app listing page. | ||
|
|
||
| The module will fetch and refresh your session as the token expires, caching it locally to minimise calls to Reapit Connect token endpoint. | ||
| This has moved to [@reapit/connect-session-server](https://www.npmjs.com/package/@reapit/connect-session-server) |
There was a problem hiding this comment.
Doesn't look like you removed the code from the browser package
There was a problem hiding this comment.
willmcvay
approved these changes
Apr 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Detail as per issue below (required):
fixes: #10935