-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect Session Server throws error #10935
Comments
Would you know their typescript/javascript setup? Sounds like a esbuild/ecmascript problem? Likely that the build setup is for frontend instead of backend which can happen for many reasons. |
@bashleigh https://github.com/reapit/foundations-code-examples/tree/main/node-website-feed I found the bug trying to update the dependencies in this simple Node example - upgrade connect session and you should see |
Thanks Will. Looking at that repo I think the problem is definately related to the build of the packages. I'd recommend we split the server package out into a seperate package and or with it's own seperate build method so we can include node and other requirements without the frontend related requirements |
* feat: added connect-session-server package * refactor: remove server scripts from connect-session package * feat: resolved connect session server package * docs: removed node usage and added link to new connect-session-server package * refactor: changed lib to server lib for reapit connect server session * chore: added package scripts * feat: added connect-session-server label * chore: added jest badges for project * docs: added badges to readme * chore: easier reading of condition for sonarcloud * fix: replaced connect-session with connect-session-server package * fix: updated tsconfig path for reapit package * fix: updated node version target
Background context or User story:
Not sure how many people use it but the Connect Session server function is broken. Instantiating the
ReapitConnectServerSession
class in a simple node script throws an error "ReferenceError: self is not defined:" - my guess is one of the methods is not bound to "this".Specification or Acceptance Criteria:
Replication Steps
The text was updated successfully, but these errors were encountered: