Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong id being surfaced for developers when editing their app #161

Closed
cbryanreapit opened this issue Jan 31, 2020 · 0 comments · Fixed by #266
Closed

Wrong id being surfaced for developers when editing their app #161

cbryanreapit opened this issue Jan 31, 2020 · 0 comments · Fixed by #266
Assignees
@duong-se
Labels
bug Something isn't working front-end Relates to front end issues
Milestone
Foundations Alpha...

Comments

@cbryanreapit
Copy link
Contributor

cbryanreapit commented Jan 31, 2020 •
edited
Loading

Summary:

When a developer has registered their application, they need to receive a client id from us in order to be able to be authenticated with cognito.

This is presented from the back end as 'externalId' in from GET apps/{id}/

Presently, I believe (but please confirm!) that we are surfacing 'id' from that same endpoint instead

Additionally, I would recommend we change the terminology to be "client id" rather than "app id" in this dialog to make it clearer that this data is about OAuth. A quick means of copying this ID wouldn't hurt either.

Steps to reproduce:

Login as developer, load a specific app, see screen below:
image

Expected Results:

The externalId is presented to the user (badged as client id)

Actual Results

The id is presented to the user (badged as app id)
@cbryanreapit cbryanreapit added the bug Something isn't working label Jan 31, 2020
@HollyJoyPhillips HollyJoyPhillips added the front-end Relates to front end issues label Feb 10, 2020
@willmcvay willmcvay removed their assignment Feb 12, 2020
@duong-se duong-se self-assigned this Feb 13, 2020
@duong-se duong-se mentioned this issue Feb 13, 2020
Merged
duong-se added a commit that referenced this issue Feb 13, 2020
@duong-se
fix: #161 fix wrong id surfaced for developers when edit app
6ce5602
duong-se added a commit that referenced this issue Feb 13, 2020
@duong-se
fix: #161 fix wrong id surfaced for developers when edit app (#266)
249936c
phmngocnghia pushed a commit that referenced this issue Feb 14, 2020
@duong-se @phmngocnghia
fix: #161 fix wrong id surfaced for developers when edit app (#266)
b68c215
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@duong-se
fix: #161 fix wrong id surfaced for developers when edit app (#266)
99d98ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duong-se duong-se

Labels
bug Something isn't working front-end Relates to front end issues
Projects
None yet
Milestone
Foundations Alpha Developer Release
Development

Successfully merging a pull request may close this issue.

fix: #161 fix wrong id surfaced for developers when edit app reapit/foundations
4 participants
@willmcvay @duong-se @cbryanreapit @HollyJoyPhillips