fix: #161 fix wrong id surfaced for developers when edit app (#266)

reapit · Feb 14, 2020 · b68c215 · b68c215
1 parent 9eae9a8
commit b68c215
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/packages/marketplace/src/components/ui/__tests__/__snapshots__/app-detail.tsx.snap b/packages/marketplace/src/components/ui/__tests__/__snapshots__/app-detail.tsx.snap
@@ -33,7 +33,7 @@ exports[`AppDetailModalInner should match a snapshot 1`] = `
           </p>
           <div>
             <p>
-              App ID:
+              Client ID:
             </p>
             <p />
           </div>

diff --git a/packages/marketplace/src/components/ui/app-detail.tsx b/packages/marketplace/src/components/ui/app-detail.tsx
@@ -46,7 +46,6 @@ export const AppDetail: React.FunctionComponent<AppDetailProps> = ({
   if (!data) {
     return null
   }
-
   const {
     id,
     media = [],
@@ -59,6 +58,7 @@ export const AppDetail: React.FunctionComponent<AppDetailProps> = ({
     isListed,
     isDirectApi,
     authFlow,
+    externalId,
   } = data
   const icon = media.filter(({ type }) => type === 'icon')[0]
   const carouselImages = media.filter(({ type }) => type === 'image')
@@ -111,8 +111,8 @@ export const AppDetail: React.FunctionComponent<AppDetailProps> = ({
               <>
                 <p className={styles.appInfo}>App Information</p>
                 <div key="app-id" className={styles.appInfoRow}>
-                  <p className={styles.appInfoProperty}>App ID:</p>
-                  <p>{id}</p>
+                  <p className={styles.appInfoProperty}>Client ID:</p>
+                  <p>{externalId}</p>
                 </div>
                 <div key="app-listed" className={styles.appInfoRow}>
                   <p className={styles.appInfoProperty}>Status:</p>

diff --git a/packages/marketplace/src/tests/badges/badge-branches.svg b/packages/marketplace/src/tests/badges/badge-branches.svg
diff --git a/packages/marketplace/src/tests/badges/badge-lines.svg b/packages/marketplace/src/tests/badges/badge-lines.svg
diff --git a/packages/marketplace/src/tests/badges/badge-statements.svg b/packages/marketplace/src/tests/badges/badge-statements.svg
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,7 +33,7 @@ exports[`AppDetailModalInner should match a snapshot 1`] = ` @@
               </p>
               <div>
                 <p>
-                  App ID:
+                  Client ID:
                 </p>
                 <p />
               </div>
@@ Expand Down @@