Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCOCOA-2334: Move initial subscription logic into Core #8549
RCOCOA-2334: Move initial subscription logic into Core #8549
Changes from 1 commit
58169d8
3cd45c8
a992af1
5d6951a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 23 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L23
Check notice on line 266 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L266
Check notice on line 409 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L409
Check notice on line 797 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L797
Check notice on line 820 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L820
Check notice on line 862 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L862
Check notice on line 882 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L882
Check notice on line 1050 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L1050
Check notice on line 1097 in Realm/ObjectServerTests/AsyncSyncTests.swift
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS
Realm/ObjectServerTests/AsyncSyncTests.swift#L1097
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No space after the colon in obj-c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of spots with extra spaces between the colon and the argument and not just here.
(I think the historical reason behind this style is that it makes word-wrapping work much better and obj-c is prone to very long message sends that need wrapping).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, will go over those!