RCOCOA-2334: Move initial subscription logic into Core #8549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [04969a5] Move initial subscription logic into Core
nirinchev
force-pushed
the
ni/initial-subscriptions-in-core
branch
from
7e3c7a0 to
58169d8
Compare
tgoyne
reviewed
Apr 15, 2024
| @param callback Callback that will be invoked to update the subscriptions for this Realm file when it's first created or every time it's opened if `rerunOnOpen` is `true`. | ||
| @param rerunOnOpen A flag controlling whether to run the subscription callback every time the Realm is opened or only the first time. | ||
| */ | ||
| - (instancetype)initWithCallback:(RLMFlexibleSyncInitialSubscriptionsBlock)callback rerunOnOpen: (BOOL)rerunOnOpen; |
There was a problem hiding this comment.
No space after the colon in obj-c.
There was a problem hiding this comment.
There's a bunch of spots with extra spaces between the colon and the argument and not just here.
(I think the historical reason behind this style is that it makes word-wrapping work much better and obj-c is prone to very long message sends that need wrapping).
There was a problem hiding this comment.
Oh, sorry, will go over those!
tgoyne
approved these changes
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8548
TODO: