Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCOCOA-2334: Move initial subscription logic into Core #8549

Merged
merged 4 commits into from
Apr 22, 2024

Address CR comments

3cd45c8
Select commit
Loading
Failed to load commit list.
Merged

RCOCOA-2334: Move initial subscription logic into Core #8549

Address CR comments
3cd45c8
Select commit
Loading
Failed to load commit list.
Xcode Cloud / RealmSwift | sync_15.3 | Test - macOS succeeded Apr 15, 2024 in 5m 6s

21 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 21

Details

21 Warnings

Details

  Realm/ObjectServerTests/SwiftSyncTestCase.swift:55
      Main actor-isolated class 'SwiftSyncTestCase' has different actor isolation from nonisolated superclass 'RLMSyncTestCase'; this is an error in Swift 6
  Realm/ObjectServerTests/AsyncSyncTests.swift:820
      Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races
  Realm/RLMAsyncTask_Private.h:21
      Double-quoted include "RLMRealm_Private.h" in framework header, expected angle-bracketed instead
  Realm/ObjectServerTests/AsyncSyncTests.swift:862
      Non-sendable type 'Realm' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary
  No App Category is set for target 'TestHost'. Set a category by using the General tab for your target, or by adding an appropriate LSApplicationCategory value to your Info.plist.
  RealmSwift/Realm.swift:1328
      Passing argument of non-sendable type 'Realm' into actor-isolated context may introduce data races
  Realm/ObjectServerTests/AsyncSyncTests.swift:409
      Non-sendable type '[AnyHashable : Any]' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary
  Realm/ObjectServerTests/RealmServer.swift:493
      Static property 'shared' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6
  Realm/ObjectServerTests/AsyncSyncTests.swift:882
      Non-sendable type 'Realm' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary
  Realm/ObjectServerTests/TimeoutProxyServer.swift:67
      Converting non-sendable function value to '@Sendable (NWConnection) -> Void' may introduce data races
  Realm/ObjectServerTests/AsyncSyncTests.swift:1097
      Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races
  Realm/RLMResults_Private.h:21
      Double-quoted include "RLMRealm_Private.h" in framework header, expected angle-bracketed instead
  Realm/ObjectServerTests/AsyncSyncTests.swift:23
      Add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'RealmSwift'
  Realm/ObjectServerTests/SwiftMongoClientTests.swift:784
      Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races
  Realm/ObjectServerTests/AsyncSyncTests.swift:1050
      Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races
  Direct access in function 'realm::sync::InstructionApplier::operator()(realm::sync::instr::SetErase const&)::SetEraseResolver::on_set(realm::SetBase&)' from file '/Volumes/workspace/DerivedData/Build/Products/Release/librealm-monorepo.a(instruction_applier.o)' to global weak symbol 'typeinfo for realm::Set' from file '/Volumes/workspace/DerivedData/Build/Products/Release/librealm-monorepo.a(set.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
  RealmSwift/Realm.swift:1352
      Passing argument of non-sendable type 'RLMRealm' outside of actor-isolated context may introduce data races
  Realm/ObjectServerTests/SwiftMongoClientTests.swift:773
      Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races
  Realm/ObjectServerTests/AsyncSyncTests.swift:797
      Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races
  Realm/ObjectServerTests/AsyncSyncTests.swift:266
      Non-sendable type 'Realm' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary
  Direct access in function 'realm::sync::InstructionApplier::operator()(realm::sync::instr::SetInsert const&)::SetInsertResolver::on_set(realm::SetBase&)' from file '/Volumes/workspace/DerivedData/Build/Products/Release/librealm-monorepo.a(instruction_applier.o)' to global weak symbol 'typeinfo for realm::Set' from file '/Volumes/workspace/DerivedData/Build/Products/Release/librealm-monorepo.a(set.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

Annotations

Check notice on line 820 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L820

Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races

Check notice on line 862 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L862

Non-sendable type 'Realm' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary

Check notice on line 409 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L409

Non-sendable type '[AnyHashable : Any]' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary

Check notice on line 882 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L882

Non-sendable type 'Realm' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary

Check notice on line 1097 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L1097

Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races

Check notice on line 23 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L23

Add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'RealmSwift'

Check notice on line 1050 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L1050

Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races

Check notice on line 797 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L797

Passing argument of non-sendable type 'XCTestCase' outside of main actor-isolated context may introduce data races

Check notice on line 266 in Realm/ObjectServerTests/AsyncSyncTests.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / RealmSwift | sync_15.3 | Test - macOS

Realm/ObjectServerTests/AsyncSyncTests.swift#L266

Non-sendable type 'Realm' returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary