Fix a crash on non-@objc String? properties
#5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5713 made it so that optional Swift properties of a supported data type (i.e. `String?` and object links) which do not have ivars due to not being declared as `@objc dynamic` would crash rather than merely fail to actually read and update the managed value when the property is used. The idea behavior here would be to throw an error on schema initialization as it's an invalid model declaration, but that's a breaking change (as such objects do work correctly when unmanaged), so for now this just restores the pre-3.5.0 behavior.
cmelchior
approved these changes
May 28, 2018
| @@ -90,17 +90,24 @@ void RLMInitializeSwiftAccessorGenerics(__unsafe_unretained RLMObjectBase *const | |||
| } | |||
|
|
|||
| for (RLMProperty *prop in object->_objectSchema.swiftGenericProperties) { | |||
| id ivar = object_getIvar(object, prop.swiftIvar); | |||
| if (!ivar) { | |||
| // FIXME: this should actually be an error as it's the result of an | |||
There was a problem hiding this comment.
Is there an issue tracking this, so we remember fixing it for the next major version?
| @@ -123,6 +123,10 @@ - (void)doesNotRecognizeSelector:(SEL)aSelector { | |||
| } | |||
|
|
|||
| id RLMGetOptional(__unsafe_unretained RLMOptionalBase *const self) { | |||
| if (!self) { | |||
| // FIXME: this should actually be an error | |||
There was a problem hiding this comment.
Same as above. Link to issue.
| @@ -132,6 +136,10 @@ id RLMGetOptional(__unsafe_unretained RLMOptionalBase *const self) { | |||
| } | |||
|
|
|||
| void RLMSetOptional(__unsafe_unretained RLMOptionalBase *const self, __unsafe_unretained const id value) { | |||
| if (!self) { | |||
| // FIXME: this should actually be an error | |||
There was a problem hiding this comment.
Same as above. Link to issue.
This was referenced Sep 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5713 made it so that optional Swift properties of a supported data type (i.e.
String?and object links) which do not have ivars due to not being declared as@objc dynamicwould crash rather than merely fail to actually read and update the managed value when the property is used.The idea behavior here would be to throw an error on schema initialization as it's an invalid model declaration, but that's a breaking change (as such objects do work correctly when unmanaged), so for now this just restores the pre-3.5.0 behavior.
Fixes #5781.