Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling from Jesper (and much more) #30

Merged
merged 6 commits into from
Feb 25, 2014
Merged

Error handling from Jesper (and much more) #30

merged 6 commits into from
Feb 25, 2014

Conversation

kspangsege
Copy link
Contributor

Test suite and iPhone example is now running without issues.

There is a problem in one of the documentation examples though:

doc/ref/examples/ex_objc_table_typed_intro.m:30:
        [table addOrInsertRowAtIndex:[table count]
                                Name:@"Jesper"
                                 Age:200];

I have also added a number of FIXMEs, some of which I think we need to fix before merging.

@mekjaer @bmunkholm

@kspangsege
Copy link
Contributor Author

Note that you can run the documentation examples as follows:

sh build.sh check-doc-examples

mekjaer
mekjaer reviewed Feb 25, 2014
View reviewed changes
doc/ref/examples/ex_objc_group_intro.m

TightdbGroup *groupFromMemory = [TightdbGroup groupWithBuffer:buffer size:size];
PeopleTable *tableFromMemery = [groupFromMemory getTable:@"people" withClass:[PeopleTable class] error:nil];
/* Creates a group from an im memory buffer */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo im => in

@mekjaer
Copy link
Contributor

mekjaer commented Feb 25, 2014

otherwise 👍
Good job @kspangsege !!

mekjaer
mekjaer reviewed Feb 25, 2014
View reviewed changes
doc/ref/examples/ex_objc_table_typed_intro.m
@@ -28,6 +27,10 @@ int main()
cursor.Name = @"Sofie";
cursor.Age = 40;

[table addOrInsertRowAtIndex:[table count]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this from now.

@kspangsege
Fixing ex_objc_table_typed_intro.m
f9c32ab
@kspangsege
Merge branch 'master' into ks-error-handling-from-jesper
6cd9213
@kspangsege
Renaming types:
05cab2e 
TightdbSharedGroupReadTransactionBlock -> TightdbReadBlock
TightdbSharedGroupWriteTransactionBlock -> TightdbWriteBlock
Renaming TightdbSharedGroup selectors:
readTransactionWithBlock: -> readWithBlock:
writeTransactionWithError:withBlock: -> writeWithBlock:withError:
@kspangsege
Adding FIXME regarding removal of insert methods from public Obj-C API
3d10d8a
kspangsege added a commit that referenced this pull request Feb 25, 2014
@kspangsege
Merge pull request #30 from Tightdb/ks-error-handling-from-jesper
1357455 
Error handling from Jesper (and much more)
@kspangsege kspangsege merged commit 1357455 into master Feb 25, 2014
@kspangsege kspangsege deleted the ks-error-handling-from-jesper branch February 25, 2014 14:45
@issue2k issue2k mentioned this pull request Apr 20, 2015
Closed
@chodges chodges mentioned this pull request Mar 12, 2016
Closed
@n3d1117 n3d1117 mentioned this pull request Mar 13, 2016
Closed
@Ankish Ankish mentioned this pull request Oct 14, 2016
Closed
@emuye emuye mentioned this pull request Dec 8, 2016
Closed
jpsim added a commit that referenced this pull request Feb 6, 2017
@jpsim
fix crash in test with Swift 3.1
db13fba 
I'm not sure why this fixes the crash.

Traceback (most recent call last):
  File "/Users/jp/Library/Application Support/Realm/rlm_lldb.py", line 226, in RLMResults_SummaryProvider
    if not is_results_evaluated(obj):
  File "/Users/jp/Library/Application Support/Realm/rlm_lldb.py", line 213, in is_results_evaluated
    mode_query_value = next(m for m in mode_type.enum_members if m.name == 'Query').GetValueAsUnsigned()
StopIteration
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x00007fffcebe8ae6 libobjc.A.dylib`lookUpImpOrForward + 79
    frame #1: 0x00007fffcebe85d4 libobjc.A.dylib`_objc_msgSend_uncached + 68
    frame #2: Realm`-[RLMResults deleteObjectsFromRealm]::$_14::operator(this=0x00007fff5fbfb8c8)() const at RLMResults.mm:424
    frame #3: Realm`auto translateErrors<-[RLMResults deleteObjectsFromRealm]::$_14>(f=0x00007fff5fbfb8c8, aggregateMethod=0x0000000000000000) at RLMResults.mm:108
    frame #4: Realm`::-[RLMResults deleteObjectsFromRealm](self=0x000000010230bb10, _cmd="deleteObjectsFromRealm") at RLMResults.mm:417
    frame #5: Realm`::-[RLMRealm deleteObjects:](self=0x00006080000a2ca0, _cmd="deleteObjects:", array=(None[0])) at RLMRealm.mm:623
    frame #6: RealmSwift`Realm.delete<A where ...> (objects=<unavailable>, self=0x0000608000030040) -> () at Realm.swift:404
    frame #7: RealmSwift Tests`RealmTests.(realm=0x0000608000030040) -> ()).(closure #1) at RealmTests.swift:435
    frame #8: RealmSwift`Realm.write(block=0x0000000104a35270 RealmSwift Tests`RealmSwift_Tests.RealmTests.(testDeleteResults () -> ()).(closure #1) at RealmTests.swift:430, self=0x0000608000030040, $error=Error @ 0x00007fff5fbfbe40) throws -> ()) throws -> () at Realm.swift:124
    frame #9: RealmSwift Tests`RealmTests.testDeleteResults(self=0x0000608000089fb0) -> () at RealmTests.swift:437
    frame #10: RealmSwift Tests`@objc RealmTests.testDeleteResults() -> () at RealmTests.swift:0
    frame #11: 0x00007fffb9f733ec CoreFoundation`__invoking___ + 140
    frame #12: 0x00007fffb9f73271 CoreFoundation`-[NSInvocation invoke] + 289
    frame #13: 0x00000001000c847c XCTest`__24-[XCTestCase invokeTest]_block_invoke.234 + 50
    frame #14: 0x000000010010dcd6 XCTest`-[XCTMemoryChecker _assertInvalidObjectsDeallocatedAfterScope:] + 37
    frame #15: 0x00000001000c8040 XCTest`__24-[XCTestCase invokeTest]_block_invoke_2 + 665
    frame #16: 0x0000000100105916 XCTest`-[XCTestContext performInScope:] + 190
    frame #17: 0x00000001000c7d94 XCTest`-[XCTestCase invokeTest] + 254
    frame #18: RealmSwift Tests`TestCase.(self=0x0000608000089fb0) -> ()).(closure #1) at TestCase.swift:79
    frame #19: RealmSwift Tests`thunk at TestCase.swift:0
    frame #20: RealmSwift Tests`partial apply for thunk at TestCase.swift:0
    frame #21: 0x00000001021ef5c8 libswiftObjectiveC.dylib`ObjectiveC.autoreleasepool <A> (invoking : () throws -> A) throws -> A + 56
    frame #22: RealmSwift Tests`TestCase.invokeTest(self=0x0000608000089fb0) -> () at TestCase.swift:79
    frame #23: RealmSwift Tests`@objc TestCase.invokeTest() -> () at TestCase.swift:0
    frame #24: 0x00000001000c8803 XCTest`-[XCTestCase performTest:] + 565
    frame #25: 0x00000001000c5776 XCTest`__27-[XCTestSuite performTest:]_block_invoke + 300
    frame #26: 0x00000001000c5366 XCTest`-[XCTestSuite _performProtectedSectionForTest:testSection:] + 29
    frame #27: 0x00000001000c554c XCTest`-[XCTestSuite performTest:] + 214
    frame #28: 0x00000001000c5776 XCTest`__27-[XCTestSuite performTest:]_block_invoke + 300
    frame #29: 0x00000001000c5366 XCTest`-[XCTestSuite _performProtectedSectionForTest:testSection:] + 29
    frame #30: 0x00000001000c554c XCTest`-[XCTestSuite performTest:] + 214
    frame #31: 0x00000001000c5776 XCTest`__27-[XCTestSuite performTest:]_block_invoke + 300
    frame #32: 0x00000001000c5366 XCTest`-[XCTestSuite _performProtectedSectionForTest:testSection:] + 29
    frame #33: 0x00000001000c554c XCTest`-[XCTestSuite performTest:] + 214
    frame #34: 0x000000010011883c XCTest`__44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 40
    frame #35: 0x00000001000dbe0e XCTest`-[XCTestObservationCenter _observeTestExecutionForBlock:] + 587
    frame #36: 0x00000001001186da XCTest`-[XCTTestRunSession runTestsAndReturnError:] + 281
    frame #37: 0x00000001000b11fb XCTest`-[XCTestDriver runTestsAndReturnError:] + 254
    frame #38: 0x0000000100107fc9 XCTest`_XCTestMain + 773
    frame #39: 0x00007fffb9f957dc CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
    frame #40: 0x00007fffb9f767e4 CoreFoundation`__CFRunLoopDoBlocks + 356
    frame #41: 0x00007fffb9f75f65 CoreFoundation`__CFRunLoopRun + 917
    frame #42: 0x00007fffb9f75974 CoreFoundation`CFRunLoopRunSpecific + 420
    frame #43: 0x00007fffb9501a5c HIToolbox`RunCurrentEventLoopInMode + 240
    frame #44: 0x00007fffb9501799 HIToolbox`ReceiveNextEventCommon + 184
    frame #45: 0x00007fffb95016c6 HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 71
    frame #46: 0x00007fffb7aa75b4 AppKit`_DPSNextEvent + 1120
    frame #47: 0x00007fffb8221d6b AppKit`-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2789
    frame #48: 0x00007fffb7a9bf35 AppKit`-[NSApplication run] + 926
    frame #49: 0x00007fffb7a66850 AppKit`NSApplicationMain + 1237
    frame #50: TestHost`main(argc=5, argv=0x00007fff5fbfef58) at main.m:40
    frame #51: 0x00007fffcf4d9255 libdyld.dylib`start + 1
    frame #52: 0x00007fffcf4d9255 libdyld.dylib`start + 1
@sblepa sblepa mentioned this pull request Feb 14, 2017
Closed
@MV-EricDeHaan MV-EricDeHaan mentioned this pull request Sep 5, 2019
Closed
@jain-mj jain-mj mentioned this pull request Jul 30, 2020
Closed
@pierre-wehbe pierre-wehbe mentioned this pull request Jun 15, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kspangsege @mekjaer