MVP combined #1323
Merged
MVP combined #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switched from internal serialization implementation to realm-js (AWAITING version realm-js with this feature). * JSON serialization in changelog * linting * Skip embedded object schemas in JSON export * Update CHANGELOG.md Co-authored-by: Kræn Hansen <[email protected]> * Realm.JsonSerializationReplacer comment Co-authored-by: Kræn Hansen <[email protected]>
* embedded object warning as info text * append " (embedded)" to grid header-type * display non-sortable headers in another color than "links" * AddColumnControl: never hidden, now expands with text on hover * linting * Logging enabled for "npm run dev" * Disabled editMode for primary keys * embedded object(s) CRUD using SingleObjectCollection * Reordering fix for list of embedded objects * Nummeric => Numeric * "indices" consistency * Changelog updated * Spelling Co-authored-by: Kenneth Geisshirt <[email protected]> * Update src/ui/RealmBrowser/focus.ts Co-authored-by: Kræn Hansen <[email protected]> * Alert banner naming (type => color) Co-authored-by: Kræn Hansen <[email protected]> * Embedded info banner wording Co-authored-by: Kræn Hansen <[email protected]> * Comment * jsdoc description for SingleObjectCollection * Cleanup * General alignment from PR change commits * Moved EditMode override. * linting * removed unused $medium timing * SingleObjectCollection checks in lists * Moving embedded info instantiation * onCreate fixed after refactor * ISingleObjectFocus introduced in favor of SingleObjectCollection type checks. ISingleObjectFocus cleanup Co-authored-by: Kenneth Geisshirt <[email protected]> Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
kraenhansen
approved these changes
Sep 11, 2020
* realm bumped to v10.0.0-beta.13 * Changelog corrected to "v10.0.0-beta.13"
* Added a clean build before running tests as dev build with ELECTRON_ENABLE_LOGGING=1 otherwise blocks spectron. * (WIP) JS & TS schema exports updated with ObjectId, Decimal128 & Embedded Objects. * swift draft * Java draft * Kotlin draft * C# draft * embedded property renaming * comment * Include new exported files in tests (c#, java & kotlin) * Arrays * C# suggestions from code review Co-authored-by: Nikola Irinchev <[email protected]> * C# export corrections & filteredProperties util. * Java & kotlin export corrections * Java & kotlin export corrections - the missing parts * "type" included in error message * reverted build before test-run. * Added todos for cleanup. * Changelog entry added for schema export * realm file format updated for csv import test Co-authored-by: Nikola Irinchev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR holds:
toJSONhandling.ObjectId,Decimal128& Embedded Objects.This will close #1312 and closes #1301