Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON export #1315

Merged
merged 6 commits into from
Sep 3, 2020
Merged

JSON export #1315

merged 6 commits into from
Sep 3, 2020

Conversation

steffenagger
Copy link
Contributor

@steffenagger steffenagger commented Jul 10, 2020

Utilizing Realm.Collection.toJSON from [email protected] to generate JSON export & support circular structures.

This closes #1312

@steffenagger steffenagger self-assigned this Jul 27, 2020
@steffenagger steffenagger changed the base branch from channel/beta to sa/realm-beta.10-update August 31, 2020 11:57
@steffenagger steffenagger marked this pull request as ready for review August 31, 2020 12:15
@steffenagger steffenagger requested a review from kneth September 1, 2020 08:11
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just two minor suggestions.

src/services/data-exporter/json.ts Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@steffenagger steffenagger merged commit b5f9653 into sa/realm-beta.10-update Sep 3, 2020
@steffenagger steffenagger deleted the sa/json-export branch September 3, 2020 07:26
steffenagger added a commit that referenced this pull request Sep 23, 2020
* 'object id' & 'decimal' renamed to 'objectId' & 'decimal128'

* realm bumped to 10.0.0-beta.11

* electron version bumped from 8.1.1 to 8.4.1

* Electron v8.4.1 & Realm [email protected] added to changelog

* linting

* JSON export (#1315)

* Switched from internal serialization implementation to realm-js (AWAITING version realm-js with this feature).

* JSON serialization in changelog

* linting

* Skip embedded object schemas in JSON export

* Update CHANGELOG.md

Co-authored-by: Kræn Hansen <[email protected]>

* Realm.JsonSerializationReplacer comment

Co-authored-by: Kræn Hansen <[email protected]>

* Realm bumped to 10.0.0-beta.12 from 10.0.0-beta.11

* Designated flow for Embedded Objects (#1321)

* embedded object warning as info text

* append " (embedded)" to grid header-type

* display non-sortable headers in another color than "links"

* AddColumnControl: never hidden, now expands with text on hover

* linting

* Logging enabled for "npm run dev"

* Disabled editMode for primary keys

* embedded object(s) CRUD using SingleObjectCollection

* Reordering fix for list of embedded objects

* Nummeric => Numeric

* "indices" consistency

* Changelog updated

* Spelling

Co-authored-by: Kenneth Geisshirt <[email protected]>

* Update src/ui/RealmBrowser/focus.ts

Co-authored-by: Kræn Hansen <[email protected]>

* Alert banner naming (type => color)

Co-authored-by: Kræn Hansen <[email protected]>

* Embedded info banner wording

Co-authored-by: Kræn Hansen <[email protected]>

* Comment

* jsdoc description for SingleObjectCollection

* Cleanup

* General alignment from PR change commits

* Moved EditMode override.

* linting

* removed unused $medium timing

* SingleObjectCollection checks in lists

* Moving embedded info instantiation

* onCreate fixed after refactor

* ISingleObjectFocus introduced in favor of SingleObjectCollection type checks.

ISingleObjectFocus cleanup

Co-authored-by: Kenneth Geisshirt <[email protected]>
Co-authored-by: Kræn Hansen <[email protected]>
Co-authored-by: Kræn Hansen <[email protected]>

* realm bumped to v10.0.0-beta.13 (#1334)

* realm bumped to v10.0.0-beta.13

* Changelog corrected to "v10.0.0-beta.13"

* Schema exports (#1329)

* Added a clean build before running tests as dev build with ELECTRON_ENABLE_LOGGING=1 otherwise blocks spectron.

* (WIP) JS & TS schema exports updated with ObjectId, Decimal128 & Embedded Objects.

* swift draft

* Java draft

* Kotlin draft

* C# draft

* embedded property renaming

* comment

* Include new exported files in tests (c#, java & kotlin)

* Arrays

* C# suggestions from code review

Co-authored-by: Nikola Irinchev <[email protected]>

* C# export corrections & filteredProperties util.

* Java & kotlin export corrections

* Java & kotlin export corrections - the missing parts

* "type" included in error message

* reverted build before test-run.

* Added todos for cleanup.

* Changelog entry added for schema export

* realm file format updated for csv import test

Co-authored-by: Nikola Irinchev <[email protected]>

* linting

Co-authored-by: Kræn Hansen <[email protected]>
Co-authored-by: Kenneth Geisshirt <[email protected]>
Co-authored-by: Kræn Hansen <[email protected]>
Co-authored-by: Nikola Irinchev <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants