Migrating from util::Optional to std::optional since Realm Core is moving that way
#6449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
changed the title
tul::Optional to std::optional since Realm Core is moving that wayutil::Optional to std::optional since Realm Core is moving that way
kneth
commented
Jan 30, 2024
elle-j
approved these changes
Jan 31, 2024
CHANGELOG.md
Outdated
Comment on lines
19
to
20
| <!-- * Either mention core version or upgrade --> | ||
| <!-- * Using Realm Core vX.Y.Z --> | ||
| <!-- * Upgraded Realm Core from vX.Y.Z to vA.B.C --> |
There was a problem hiding this comment.
Suggested change
| <!-- * Either mention core version or upgrade --> | |
| <!-- * Using Realm Core vX.Y.Z --> | |
| <!-- * Upgraded Realm Core from vX.Y.Z to vA.B.C --> |
package-lock.json
Outdated
There was a problem hiding this comment.
This one changed because of commander and @commander-js/extra-typings switching versions in bindgen to v11.
There was a problem hiding this comment.
Yep 👍 It's expected and will also happen when we pull in realm/realm-core#7299.
You could probably leave those updates out of this PR and add them on the PR upgrading to an upcoming Core release instead 👍
kraenhansen
approved these changes
Feb 1, 2024
kneth
force-pushed
the
kneth/optional
branch
2 times, most recently
from
b01469f to
e58efbe
Compare
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
…s moving that way (realm#6449) * Migrating from `tul::Optional` to `std::optional` since Realm Core is moving that way * Update core * Update CHANGELOG.md * Make linter great again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The Realm Core team wishes to stop using
util::Optionaland start usingstd::optional. Currentlyutil::Optionalis an alias but will eventually disappear. Together with realm/realm-core#7284 we are preparing for the future.Not sure why
package-lock.jsonneeds to be updated.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary