Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bindgen] Upgraded eslint plugins + adding prettier as a dep #7299

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This upgrades two dependencies of the bindgen package and adds a missing dependency.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kraenhansen kraenhansen self-assigned this Jan 27, 2024
@cla-bot cla-bot bot added the cla: yes label Jan 27, 2024
@kraenhansen kraenhansen changed the title [bindgen] Upgraded eslint-*-prettier + prettier as a dep [bindgen] Upgraded eslint plugins + adding prettier as a dep Jan 27, 2024
Copy link

coveralls-official bot commented Jan 27, 2024

Pull Request Test Coverage Report for Build kraen.hansen_51

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.01%) to 91.828%

Files with Coverage Reduction New Missed Lines %
test/test_index_string.cpp 1 94.13%
src/realm/object-store/shared_realm.cpp 2 93.03%
src/realm/query_expression.hpp 2 93.59%
src/realm/sync/noinst/server/server_history.cpp 2 67.94%
src/realm/sync/client.cpp 3 91.1%
test/test_util_network.cpp 3 97.2%
src/realm/sync/noinst/client_reset.cpp 4 92.96%
src/realm/util/assert.hpp 4 87.1%
src/realm/index_string.cpp 6 87.87%
src/realm/sync/network/network.cpp 6 89.46%
Totals Coverage Status
Change from base Build 1994: -0.01%
Covered Lines: 235169
Relevant Lines: 256096

💛 - Coveralls

@kraenhansen kraenhansen requested review from jedelbo and kneth January 30, 2024 07:00
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kenneth Geisshirt <[email protected]>
@kraenhansen kraenhansen merged commit 1a8c84c into master Jan 31, 2024
36 checks passed
@kraenhansen kraenhansen deleted the kh/eslint-prettier-upgraded branch January 31, 2024 18:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants