Upgrade to Realm Core 13.2.0 #5252
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| PACKAGE_NAME=realm-js | ||
| VERSION=11.4.0 | ||
| REALM_CORE_VERSION=13.2.0 | ||
| NAPI_VERSION=5 | ||
| MDBREALM_TEST_SERVER_TAG=2022-06-10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -134,40 +134,91 @@ module.exports = { | |||||
| }, | ||||||
|
|
||||||
| /** | ||||||
| * | ||||||
| * References: | ||||||
| * - https://github.com/facebook/react-native/blob/main/Libraries/Utilities/Platform.ios.js | ||||||
| * - https://github.com/facebook/react-native/blob/main/Libraries/Utilities/NativePlatformConstantsAndroid.js | ||||||
| * | ||||||
| * @returns An object with names and versions of the various components making up the context. | ||||||
| */ | ||||||
| getVersions() { | ||||||
| const packageJson = require("../package.json"); | ||||||
| const sdkVersion = packageJson.version; | ||||||
| const environment = this.getEnvironment(); | ||||||
|
|
||||||
| const sdk = "JS"; | ||||||
|
|
||||||
| try { | ||||||
| if (environment === "reactnative") { | ||||||
| const { Platform } = require("react-native"); | ||||||
| let deviceName = "unknown"; | ||||||
| let deviceVersion = "unknown"; | ||||||
| if (Platform.OS === "ios") { | ||||||
| if (Platform.isPad()) { | ||||||
| deviceName = "iPad"; | ||||||
| } else if (Platform.isTV()) { | ||||||
| deviceName = "AppleTV"; | ||||||
| } else { | ||||||
| // RN doesn't support Apple Watch | ||||||
| deviceName = "iPhone"; | ||||||
| } | ||||||
| deviceVersion = "unknown"; | ||||||
|
There was a problem hiding this comment. You should be able to use
Suggested change
There was a problem hiding this comment. I haven't found a way to tell me if it is an iPhone 10 or iPhone 11. |
||||||
| } else if (Platform.OS === "android") { | ||||||
| deviceName = `${Platform.Manufacturer}:${Platform.Brand}`; | ||||||
kneth marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| deviceVersion = `${Platform.Model}`; | ||||||
|
There was a problem hiding this comment. The react native docs on this, describes the
What is the intended semantics of this property exactly? There was a problem hiding this comment. The specification split "Samsung GT-I9100" so deviceName is "Samsung" and deviceVersion is "GT-I9100", and I have interpreted deviceVersion as the model. |
||||||
| } | ||||||
|
|
||||||
| return { | ||||||
| sdk, | ||||||
| sdkVersion, | ||||||
|
|
||||||
| platform: Platform.OS, | ||||||
| // Android reports a number ... | ||||||
| platformVersion: `${Platform.Version}`, | ||||||
|
|
||||||
| deviceName, | ||||||
| deviceVersion, | ||||||
|
|
||||||
| cpuArch: "unknown", // Detecting CPU architecture on Android and iOS is done by seperate methods in platform.{mm, cpp) | ||||||
|
|
||||||
| frameworkName: "RN", | ||||||
kneth marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| frameworkVersion: Object.values(Platform.constants.reactNativeVersion).join("."), | ||||||
| }; | ||||||
| } else if (environment === "node.js" || environment === "electron") { | ||||||
| const platform = os.type(); // eslint-disable-line | ||||||
| const platformVersion = os.release(); // eslint-disable-line | ||||||
| const cpuArch = os.arch(); // eslint-disable-line | ||||||
|
|
||||||
| return { | ||||||
| sdk, | ||||||
| sdkVersion, | ||||||
|
|
||||||
| platform, | ||||||
| platformVersion, | ||||||
|
|
||||||
| deviceName: "unknown", | ||||||
| deviceVersion: "unknown", | ||||||
|
|
||||||
| cpuArch, | ||||||
|
|
||||||
| frameworkName: environment, | ||||||
| frameworkVersion: process.versions.electron || process.version, | ||||||
| }; | ||||||
| } | ||||||
| } catch (err) { | ||||||
| console.warn("Error getting versions:", err.stack); | ||||||
| } | ||||||
|
|
||||||
| return { | ||||||
| platform: "unknown-platform", | ||||||
| platformVersion: "?.?.?", | ||||||
| sdkVersion: "?.?.?", | ||||||
| sdk: "unknown-sdk", | ||||||
| cpuArch: "unknown-cpu-arch", | ||||||
| deviceName: "unknown-device-name", | ||||||
| deviceVersion: "?.?.?", | ||||||
| frameworkName: "unknown-framework-name", | ||||||
| frameworkVersion: "?.?.?", | ||||||
kneth marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| }; | ||||||
| }, | ||||||
| }; | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kneth, these caused a regression since
Platform.isPadandPlatform.isTVare boolean properties (not methods).Please see: https://reactnative.dev/docs/platform#ispad-ios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@appden Thank you for reporting. I have a fix in #5491.