Upgrade to Realm Core 13.2.0 #5252
Conversation
kneth
force-pushed
the
kneth/core-13.2.0
branch
from
ff373ab to
f13c4f4
Compare
kneth
force-pushed
the
kneth/core-13.2.0
branch
from
e9db185 to
5c97c7b
Compare
| deviceVersion = "unknown"; | ||
| } else if (Platform.OS === "android") { | ||
| deviceName = `${Platform.Manufacturer}:${Platform.Brand}`; | ||
| deviceVersion = `${Platform.Model}`; |
There was a problem hiding this comment.
The react native docs on this, describes the Model as:
The end-user-visible name for the Android device.
What is the intended semantics of this property exactly?
There was a problem hiding this comment.
The specification split "Samsung GT-I9100" so deviceName is "Samsung" and deviceVersion is "GT-I9100", and I have interpreted deviceVersion as the model.
| // RN doesn't support Apple Watch | ||
| deviceName = "iPhone"; | ||
| } | ||
| deviceVersion = "unknown"; |
There was a problem hiding this comment.
You should be able to use osVersion here:
| deviceVersion = "unknown"; | |
| deviceVersion = Platform.osVersion; |
There was a problem hiding this comment.
I haven't found a way to tell me if it is an iPhone 10 or iPhone 11. Platform.osVersion will tell me the version of iOS or Android which is unrelated to the device.
Co-authored-by: Kræn Hansen <[email protected]>
Co-authored-by: Kræn Hansen <[email protected]>
I have updated the internal document to reflect the PR. |
| if (Platform.isPad()) { | ||
| deviceName = "iPad"; | ||
| } else if (Platform.isTV()) { |
There was a problem hiding this comment.
Hey @kneth, these caused a regression since Platform.isPad and Platform.isTV are boolean properties (not methods).
Error getting versions: TypeError: false is not a function
Please see: https://reactnative.dev/docs/platform#ispad-ios
What, How & Why?
This closes #5244
☑️ ToDos
Compatibilitylabel is updated or copied from previous entry[ ] 📝 UpdateCOMPATIBILITY.md[ ] 🚦 Tests[ ] 🔀 Executed flexible sync tests locally if modifying flexible sync[ ] 📦 Updated internal package version in consumingpackage.jsons (if updating internal packages)[ ] 📱 Check the React Native/other sample apps work if necessary[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated