Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing for Node > 14 #4149

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Tests failing for Node > 14 #4149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa33db3
Tests failing for Node > 14
takameyer Dec 15, 2021
937c0d1
Merge branch 'master' into andrew/fix/node_16_issue
takameyer Dec 16, 2021
1643db1
Merge branch 'master' into andrew/fix/node_16_issue
takameyer Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ x.x.x Release notes (yyyy-MM-dd)
* If the option `user` in a sync configuration was not a `Realm.User` object could lead to a crash. ([#1348](https://github.com/realm/realm-js/issues/1348), since v10.0.0)
* `@sum` and `@avg` queries on Dictionaries of floats or doubles used too much precision for intermediates, resulting in incorrect rounding. (since v10.3.0-rc.1)
* Queries of the form `link.collection.@sum = 0` where `link` is `null` matched when `collection` was a List or Set, but not a Dictionary ([realm/realm-core#5080](https://github.com/realm/realm-core/pull/5080), since v10.5.0)
* Fix Realm for versions of Node greater than 14.

### Compatibility
* MongoDB Realm Cloud.
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"fs-extra": "^4.0.3",
"https-proxy-agent": "^2.2.4",
"ini": "^1.3.7",
"node-addon-api": "^3.1.0",
"node-addon-api": "4.2.0",
"node-fetch": "^2.6.1",
"node-machine-id": "^1.1.10",
"prebuild-install": "^6.1.1",
Expand Down Expand Up @@ -160,4 +160,4 @@
4
]
}
}
}
2 changes: 1 addition & 1 deletion src/node/node_protected.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class Protected {
, m_isValue(false)
{
napi_status status = napi_create_reference(env, value, 1, &m_ref);
if (status == napi_object_expected) {
if (status == napi_object_expected || status == napi_invalid_arg) {
m_isValue = true;
Napi::Object object = Napi::Object::New(m_env);
object.Set("value", value);
Expand Down