Tests failing for Node > 14 #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
requested review from
kneth,
tomduncalf,
fronck,
kraenhansen and
blagoev
and removed request for
kneth
takameyer
force-pushed
the
andrew/fix/node_16_issue
branch
2 times, most recently
from
0440f9b to
de16302
Compare
tomduncalf
approved these changes
Dec 15, 2021
blagoev
reviewed
Dec 15, 2021
takameyer
force-pushed
the
andrew/fix/node_16_issue
branch
from
de16302 to
8da1149
Compare
`napi_create_reference` returns `napi_invalid_arg` instead of `napi_object_expected`. Extended logic for this case. Also updated `node-addon-api` to `4.2.0`
takameyer
force-pushed
the
andrew/fix/node_16_issue
branch
from
8da1149 to
aa33db3
Compare
fronck
approved these changes
Dec 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_create_referencereturnsnapi_invalid_arginstead ofnapi_object_expected.Extended logic for this case.
Also updated
node-addon-apito4.2.0☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: