Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Realm Sync Custom Confirmation retry functionality #4000

Merged
merged 7 commits into from
Oct 18, 2021
Merged

Expose Realm Sync Custom Confirmation retry functionality #4000

merged 7 commits into from
Oct 18, 2021

Conversation

fronck
Copy link

@fronck fronck commented Oct 6, 2021 •
edited
Loading

What, How & Why?

Support for re-running Custom Confirmation logic for Realm Sync Email/Password users.

This closes #3032.

☑️ ToDos

  • 📝 Changelog entry
    * [ ] 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
    * [ ] 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
    * [ ] Chrome debug API is updated if API is available on React Native

@fronck fronck force-pushed the ff/rerun_custom_confirm branch from b1b6550 to da6d579 Compare October 7, 2021 09:20
@fronck fronck marked this pull request as ready for review October 7, 2021 13:54
@fronck fronck changed the title Ff/rerun custom confirm Expose Realm Sync Custom Confirmation retry functionality Oct 7, 2021
tomduncalf
tomduncalf reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@tomduncalf tomduncalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't claim to know enough about the codebase yet to approve :) (although it LGTM!) but this was very helpful in seeing how a feature like this fits together end-to-end, thanks!

kneth
kneth approved these changes Oct 7, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
packages/realm-web-integration-tests/test/mocha.opts Show resolved Hide resolved
kraenhansen
kraenhansen approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cla-bot cla-bot bot added the cla: yes label Oct 13, 2021
@kneth kneth force-pushed the ff/rerun_custom_confirm branch from 54ba7ba to 4b43bbd Compare October 14, 2021 14:52
@kraenhansen kraenhansen force-pushed the ff/rerun_custom_confirm branch from 4b43bbd to af6ada4 Compare October 18, 2021 11:14
@kraenhansen
Copy link
Member

Still looks reasonable :)

@fronck fronck merged commit 4f47144 into master Oct 18, 2021
@fronck fronck deleted the ff/rerun_custom_confirm branch October 18, 2021 12:49
@fronck fronck mentioned this pull request Oct 18, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomduncalf tomduncalf tomduncalf left review comments

@kraenhansen kraenhansen kraenhansen approved these changes

@kneth kneth kneth approved these changes

Assignees

@fronck fronck

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for re-running Custom Confirmation Logic
4 participants
@fronck @kraenhansen @kneth @tomduncalf