Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for re-running Custom Confirmation Logic #3032

Closed
RealmBot opened this issue Jul 6, 2020 · 10 comments · Fixed by #4000
Closed

Add Support for re-running Custom Confirmation Logic #3032

RealmBot opened this issue Jul 6, 2020 · 10 comments · Fixed by #4000
Assignees

Comments

@RealmBot
Copy link
Collaborator

RealmBot commented Jul 6, 2020

Expose work done in Expose Retry Custom Confirmation Client API endpoint within Realm's JS SDK.

This endpoint to send the user confirmation email. 

This will alleviate this type of problems:
{quote}At Realm Web SDK, there is no method for "Resend confirmation for Function based user confirmation" at Email/Password provider.

I tried calling "app.emailPasswordAuth.resendConfirmationEmail" but it returns:
please use confirm via function (status 400)

Which would be correct. So looked in source code and tried to find the equivalent for function, but there is no such method.

Could you please provide a fix, I have the situation where users who created the account, and forgot to click the confirmation email, are never confirmed, and never able to login.

Version of Realm and Tooling
Realm JS SDK Version: Realm Web 1.0
Node or React Native: No
{quote}

@RealmBot
Copy link
Collaborator Author

RealmBot commented Jul 6, 2020

➤ On 2020-06-25, Drew DiPalma commented:

Out of curiosity – what is this blocked on?

@RealmBot
Copy link
Collaborator Author

➤ Kræn Hansen commented:

[~drew.dipalma] I don't think it's blocked? But I would for us to learn a bit more about the need for this feature and the API exposed by the server to help move this forward accordingly.
[~martin.burdette] do you have details on what this endpoint on the server does and how its supposed to be called?
[~jason.flax] do you have details on where in the SDKs API this would be good to be exposed?

@RealmBot
Copy link
Collaborator Author

➤ Martin Burdette commented:

hey I'm happy to help here if you want to hop on a call/ slack or something sometime, Or I can just try to answer questions here, let me know! (sorry for the slow reply)

@RealmBot
Copy link
Collaborator Author

➤ Ian Ward commented:

[~brian.munkholm] Can we get this added to the next sprint please?

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 26, 2020

➤ Kenneth Geisshirt commented:

[~ian.ward] Sorry for the late reply. I will add it to the next release to get it more visible.

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 8, 2020

➤ Drew DiPalma commented:

What's the latest status here? This keeps coming up as a frequent pain point.

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 8, 2020

➤ Sumedha Mehta commented:

relevant concern from developer - #3430

@kraenhansen
Copy link
Member

This is what needs to be done for Realm Web:

  • Add the "/confirm/call" route to the routes.ts named confirmCall.
  • Add a method on the EmailPasswordAuth class named retryCustomConfirmation (this is the name suggested by Realm Java) which calls the server using the confirmCall route.
  • Bonus: Add a test.

This is what needs to be done for Realm JS:

@sync-by-unito
Copy link

sync-by-unito bot commented Sep 3, 2021

➤ Stoney Burks commented:

Moving this to RFW so Franck can focus on shipping Hermes Support. We will pick this back up after Hermes launches but before starting Stub Provider (RJS-1180).

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 8, 2021

➤ Franck Franck commented:

Blocking on RJS-1367. This PR seems to more often exercise the code path that triggers segfaults in the Mixed implementation.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants