[v10] Cache Realm instances #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
force-pushed
the
kneth/v10/caching-realm-instances
branch
from
ced8d8e to
058f1a5
Compare
blagoev
approved these changes
Oct 12, 2020
| realm2.objects('StringOnlyObject'); | ||
| TestCase.assertFalse(realm1.compact()); | ||
| TestCase.assertTrue(realm1.compact()); |
There was a problem hiding this comment.
I'm guessing the test here is in the "limitation" of compact(): "Compaction will not occur if other Realm instances exist." Maybe add a comment about this?
And a question: What happens to realm2 when realm1 is closed (e.g. realm1.close())?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #3322