[v6] Cache Realm instances #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
approved these changes
Oct 9, 2020
You cannot compact an open Realm. When the two instances are the same, closing one, closes the second one. |
blagoev
approved these changes
Oct 12, 2020
blagoev
added a commit
that referenced
this pull request
Oct 12, 2020
* Porting #3322 * Update CHANGELOG.md Co-authored-by: blagoev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The introduction of Realm Core v6, Realm Object Store changed disabled the caching of Realm instances.
Currently: https://github.com/realm/realm-object-store/blob/301642fe90212c379f550656a7234f41db158ddf/src/shared_realm.hpp#L235
Pre Core v6: https://github.com/realm/realm-object-store/blob/5d8bfcac9804962945d47530f372c6f8dee77416/src/shared_realm.hpp#L234
By disabling caching, user might see growing Realm files when they forgot to call
Realm.close().☑️ ToDos
[ ] 📝Compatibilitylabel is updated or copied from previous entry[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native