RCORE-821 Update user metadata atomically #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
force-pushed
the
jbr/atomically_update_syncuser_metadata
branch
from
5896019 to
5b59473
Compare
ironage
requested changes
Sep 3, 2021
| REALM_ASSERT(state == State::Removed); | ||
| return; | ||
| case State::LoggedIn: | ||
| if (m_state == State::LoggedIn) { |
There was a problem hiding this comment.
This is always true because the switch is already on m_state. Can you double check the logic in each of these cases, did you mean to switch on state instead?
There was a problem hiding this comment.
You're right. I've simplified this a bunch and added a unit test that makes sure these code paths are exercised.
ironage
approved these changes
Sep 3, 2021
jbreams
force-pushed
the
jbr/atomically_update_syncuser_metadata
branch
from
12510df to
0bbecf8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos