Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging out a sync user should update sync user metadata atomically #4875

Closed
sync-by-unito bot opened this issue Aug 25, 2021 · 1 comment
Closed

Logging out a sync user should update sync user metadata atomically #4875

sync-by-unito bot opened this issue Aug 25, 2021 · 1 comment
Assignees
@jbreams

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 25, 2021

We currently update the sync user metadata (access token, refresh token, and state enum) in three separate realm commits. If the process crashes between those commits, we can end up trying to use a logged out user when the process starts back up.
@ironage
Copy link
Contributor

ironage commented Sep 7, 2021

Fixed by #4876

@ironage ironage closed this as completed Sep 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbreams jbreams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbreams @ironage