Stop generating object keys from primary key value hashes #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnschiermer
suggested changes
May 25, 2021
| @@ -346,7 +347,7 @@ class Table { | |||
| size_t get_index_in_group() const noexcept; | |||
| TableKey get_key() const noexcept; | |||
|
|
|||
| uint32_t allocate_sequence_number(); | |||
| uint64_t allocate_sequence_number(); | |||
test/object-store/results.cpp
Outdated
| @@ -3248,12 +3248,15 @@ TEMPLATE_TEST_CASE("results: get<Obj>() intermixed with writes", "", ResultsFrom | |||
|
|
|||
| r->begin_transaction(); | |||
|
|
|||
| /* | |||
| * We no longer insert based on pk. Objects will always be inserted at the end. | |||
There was a problem hiding this comment.
Shouldn't we just remove this code completely?
test/test_global_key.cpp
Outdated
| @@ -76,6 +76,7 @@ TEST(GlobalKey_Compare) | |||
| CHECK_LESS(GlobalKey(0, 0), GlobalKey(1, 0)); | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Shouldn't we just remove this code?
finnschiermer
suggested changes
May 25, 2021
test/test_upgrade_database.cpp
Outdated
|
|
||
| SHARED_GROUP_TEST_PATH(temp_copy); | ||
|
|
||
| // Make a copy of the version 9 database so that we keep the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #4522
☑️ ToDos