Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression for insertion with PK. #4522

Closed
finnschiermer opened this issue Mar 16, 2021 · 4 comments
Closed

Performance regression for insertion with PK. #4522

finnschiermer opened this issue Mar 16, 2021 · 4 comments
Assignees
Labels

Comments

@finnschiermer
Copy link
Contributor

finnschiermer commented Mar 16, 2021

We have a performance regression for inserting objects with a primary key. The regression was introduced with Core v6.

It is visible for commits which are relatively small compared to the table being updated.

For commits about 10% of table size there is no problem. For commits of 1% of table size there is often a problem.
The performance drop continues to increase with smaller commit sizes relative to the overall table size.

It is already the case, that writing data using few larger commits are generally faster than many smaller commits,
but this regression impacts smaller commits beyond what was the case prior to Core v6.

The regression is most pronounced for string primary keys, but may also hit integer primary keys, depending on the insertion pattern.

@finnschiermer
Copy link
Contributor Author

finnschiermer commented Mar 16, 2021

We will fix this.

In some cases it is possible to work around the problem by using an indexed property instead of setting a primary key.

@finnschiermer finnschiermer self-assigned this Mar 16, 2021
@finnschiermer finnschiermer changed the title Performance regression for writes with PK. Performance regression for insertion with PK. Mar 16, 2021
@meismyles
Copy link

I believe this issue is affecting us when updating - having to remain on an old version for now. Any idea on a timeframe to resolve?

@sync-by-unito
Copy link

sync-by-unito bot commented May 18, 2021

➤ Finn Andersen commented:

Qualified guess: A few weeks from now.

@sync-by-unito
Copy link

sync-by-unito bot commented Jun 1, 2021

➤ Finn Andersen commented:

Should be fixed by Core v11.0.0-beta.6

@sync-by-unito sync-by-unito bot closed this as completed Jun 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants