Improve failing log output of tests #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is unfortunately quite out of date due to depending on #832, and my lack of reviewing that. @norio-nomura these seem like great improvements, maybe you could update this branch once #832 lands? |
e.g.
> /Users/norio/github/SwiftLint/Tests/SwiftLintFramework/TestHelpers.swift:136: error: -[SwiftLintFrameworkTests.RulesTests testMissingDocs] : failed - nonTriggeringExample violated:
> ```
> /// docs
> public func a() {}
> ^ warning: Missing Docs Violation: Public declarations should be documented. (missing_docs)
> ```
… does not violate
e.g.
> /Users/norio/github/SwiftLint/Tests/SwiftLintFramework/TestHelpers.swift:159: error: -[SwiftLintFrameworkTests.RulesTests testValidDocs] : failed - triggeringExample did not violate:
> ```
> /// docs
> public func no() -> (Int, Int) {return (1, 2)}
> ```
…cation
e.g.
> /Users/norio/github/SwiftLint/Tests/SwiftLintFramework/TestHelpers.swift:173: error: -[SwiftLintFrameworkTests.RulesTests testMissingDocs] : failed - triggeringExample violate at unexpected location:
> ```
> public func a↓() {}
> ^ warning: Missing Docs Violation: Public declarations should be documented. (missing_docs)
> ```
…ot violated at.
e.g.
> /Users/norio/github/SwiftLint/Tests/SwiftLintFramework/TestHelpers.swift:180: error: -[SwiftLintFrameworkTests.RulesTests testMissingDocs] : failed - triggeringExample did not violate at expected location:
> ```
> public func a↓() {}
> ```
Removed: - Comparing total count of violations and expected locations from all triggering examples - Comparing count of violations and expected locations on each triggering examples - Order based comparison between violations and expected locations
norio-nomura
force-pushed
the
nn-improve-failing-log-of-tests
branch
from
1efb572 to
6ba6be2
Compare
|
Rebased. |
jpsim
approved these changes
Dec 1, 2016
| @@ -34,6 +34,38 @@ private func cleanedContentsAndMarkerOffsets(from contents: String) -> (String, | |||
| return (contents as String, markerOffsets.sorted()) | |||
| } | |||
|
|
|||
| func render(violations: [StyleViolation], in contents: String) -> String { | |||
| return (["```"] + contents + ["```"]).joined(separator: "\n") | ||
| } | ||
|
|
||
| func render(locations: [Location], in contents: String) -> String { |
| contents.insert(message, at: line) | ||
| } | ||
| } | ||
| return (["```"] + contents + ["```"]).joined(separator: "\n") |
There was a problem hiding this comment.
Isn't this equivalent and simpler?
return "```\n\(contents)\n```"There was a problem hiding this comment.
contents is [String].
| content.insert("↓", at: index) | ||
| contents[line - 1] = content | ||
| } | ||
| return (["```"] + contents + ["```"]).joined(separator: "\n") |
There was a problem hiding this comment.
Isn't this equivalent and simpler?
return "```\n\(contents)\n```"There was a problem hiding this comment.
Here also contents is [String]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On debugging failing tests, I did adhoc improvements sometime. But now, I think it should be implemented that properly.
This depends on #832
testSwiftLintAutoCorrects()nonTriggeringExamples: