Migrate to Swift 3.0 #832

norio-nomura · 2016-10-08T15:59:46Z

No description provided.

* master: Change `File.cacheKey` algorithm when `File.path` is nil # Conflicts: # Source/SwiftLintFramework/Extensions/File+Cache.swift

norio-nomura · 2016-10-14T00:10:38Z

Failing tests are affected by jpsim/SourceKitten#269.

* master: changelog formatting Remove whitespace Extract literal stripping into function, add image literal stripping Adds newlines for consistent markdown markup Fix indentation Adds enhancement entry to changelog.md Adds triggering and non-triggering example, color literals are treated as any other characters Switches to using substring replacement of temporary string in order to detect multiple color literals in one line Improves line length and whitespace to satisfy linting of source file Color literals counts as single character towards line count # Conflicts: # Source/SwiftLintFramework/Rules/LineLengthRule.swift

* master: Using character based init PR feedback Handling pattern matching cases (if case, for case, etc) Addressing PR feedback Add SwitchCaseOnNewline rule Adding CHANGELOG entry Validates if "return" in ConditionalReturnsOnNewline is a keyword Stop `make` if working tree does not have git repository # Conflicts: # Source/SwiftLintFramework/Rules/ConditionalReturnsOnNewline.swift

* master: (41 commits) Fix formatting in CHANGELOG.md release 0.13.0 Update CHANGELOG.md Fix check for trailing whitespace to return early Fix checks for some inline comments Replace check for comments to use SyntaxKind Add configuration for trailing_whitespace to ignore comments Unwanted space removed - Lint issues fixed Updated HTML Reporter PR feedback Add check on autocorrect for disabled range Use `utf8.count` instead of `utf16.count` to byte range Re-write `ExplicitInitRule` to `ASTRule` added ExplicitInitRule Updated CHANGELOG HTML Reporter added HTML Reporter added Adds information about SwiftLint plugin for AppCode into README.md added reasons why a new rule should be opt in ... # Conflicts: # Source/SwiftLintFramework/Extensions/File+SwiftLint.swift # Source/SwiftLintFramework/Extensions/Structure+SwiftLint.swift # Source/SwiftLintFramework/Rules/ColonRule.swift # Source/SwiftLintFramework/Rules/CommaRule.swift # Source/SwiftLintFramework/Rules/LegacyCGGeometryFunctionsRule.swift # Source/SwiftLintFramework/Rules/LegacyConstantRule.swift # Source/SwiftLintFramework/Rules/LegacyConstructorRule.swift # Source/SwiftLintFramework/Rules/LegacyNSGeometryFunctionsRule.swift # Source/SwiftLintFramework/Rules/LineLengthRule.swift # Source/SwiftLintFramework/Rules/OperatorFunctionWhitespaceRule.swift # Source/SwiftLintFramework/Rules/ReturnArrowWhitespaceRule.swift # Source/SwiftLintFramework/Rules/RuleConfigurations/StatementPositionConfiguration.swift # Source/SwiftLintFramework/Rules/StatementPositionRule.swift # Source/SwiftLintFramework/Rules/TrailingWhitespaceRule.swift # Tests/SwiftLintFramework/RuleConfigurationTests.swift

norio-nomura · 2016-11-04T12:46:51Z

Updated to 0.13.0

* master: fix typo: coalesing -> coalescing # Conflicts: # Source/SwiftLintFramework/Rules/RedundantNilCoalescingRule.swift

Fix crash in `hasTrailingWhitespace()` when trailing character is Emoji.

jpsim · 2016-11-25T23:40:13Z

@norio-nomura how can I help you with this?

many of which are to help with otherwise very long compile times

make lots of Swift 3 related changes

jpsim · 2016-12-01T18:53:06Z

tests related docs are still failing because of jpsim/SourceKitten#269.

That's true, but we have that limitation when using the current master version of SwiftLint with a Swift 3 codebase right now too, it's just that we don't test that configuration.

So I'd opt for disabling those tests.

Is there anything else that needs to go in this before we can merge? Every day we don't merge this just adds extra work to keep it updated with changes to master.

norio-nomura · 2016-12-01T23:40:37Z

Is there anything else that needs to go in this before we can merge?

I'm trying to replace YamlSwift with Yams. But, that is not needed to be into this.
Let's merge. 👍

jpsim · 2016-12-02T00:48:43Z

Let's disable the failing docs tests before merging, you mentioned a failure with getting the version from the bundle in SPM too. Does that still happen? Hard to tell with Travis being so ridiculously backed up. It might as well be down

jpsim/SourceKitten#269

norio-nomura · 2016-12-02T01:11:39Z

Updated.

jpsim · 2016-12-02T02:07:08Z

Should we take care of Swift 3 API Guidelines in a later PR? I'm inclined to say yes.

norio-nomura · 2016-12-02T02:18:24Z

Yeah, as inspecting search results , those will affect to only us on github. 😉

change Array.arrayOf(_:) to Array.array(of:)

norio-nomura · 2016-12-02T02:38:54Z

Maybe following would have higher priority than Swift 3 API Guidelines.

Every day we don't merge this just adds extra work to keep it updated with changes to master.

jpsim

I added a changelog entry. I think this can be merged now.

norio-nomura · 2016-12-02T02:57:06Z

CHANGELOG.md

@@ -2,7 +2,10 @@

 ##### Breaking

-* None.
+* SourceKitten now requires Xcode 8.x and Swift 3.0 to build.


~~SourceKitten~~
SwiftLint

jpsim · 2016-12-02T05:09:36Z

Anything else @norio-nomura?

norio-nomura · 2016-12-02T05:16:24Z

@jpsim None!

norio-nomura · 2016-12-02T05:28:49Z

Oh, wait a minute.

norio-nomura · 2016-12-02T05:31:12Z

Done! 😃👍

codecov-io · 2016-12-02T05:43:37Z

Current coverage is 83.86% (diff: 80.53%)

No coverage report found for master at bb515d3.

Powered by Codecov. Last update bb515d3...a0fb308

norio-nomura · 2016-12-02T05:46:41Z

I have canceled some outdated jobs on travis that triggered by my commits.

jpsim · 2016-12-02T05:53:38Z

norio-nomura added 2 commits October 7, 2016 15:25

Update dependencies

e92503a

Migrate to Swift 3.0

8bf15f1

norio-nomura force-pushed the swift3.0 branch from c50bb6c to 8bf15f1 Compare October 8, 2016 16:10

This was referenced Oct 9, 2016

Update APIs to conform to Swift 3 API Guidelines jpsim/SourceKitten#261

Closed

Add @available to swift 3 api guidelines changes jpsim/SourceKitten#265

Merged

norio-nomura added 7 commits October 13, 2016 18:44

Merge branch 'master' into swift3.0

b134008

* master: Change `File.cacheKey` algorithm when `File.path` is nil # Conflicts: # Source/SwiftLintFramework/Extensions/File+Cache.swift

Fix CSVReporter.swift

609d9f6

Fix testWhitelistRules()

9078b6c

Fix crash on JSONReporter

fc0d48a

Use Any instead of AnyObject

1c53118

Fix failing testJSONReporter()

1dc0d60

Fix line_length style violations, unused warnings

ec3f9d0

norio-nomura mentioned this pull request Oct 14, 2016

Detecting doc fails on Swift 3.0 jpsim/SourceKitten#269

Open

Remove #if swift(>=2.3)

bd8d053

norio-nomura mentioned this pull request Oct 14, 2016

Improve failing log output of tests #840

Merged

norio-nomura added 4 commits October 14, 2016 20:06

Update SourceKitten

3ff76e7

norio-nomura mentioned this pull request Nov 4, 2016

Plans for Swift 3 #816

Closed

jpsim mentioned this pull request Nov 8, 2016

Support Linux #732

Closed

norio-nomura added 5 commits November 8, 2016 18:30

Merge branch 'master' into swift3.0

34bb6a6

* master: fix typo: coalesing -> coalescing # Conflicts: # Source/SwiftLintFramework/Rules/RedundantNilCoalescingRule.swift

Update YamlSwift to 3.1.0

df28dcf

Update SourceKitten

a6b6354

Support Swift Package Manager on macOS

121d19b

Pass UnicodeScalar to CharacterSet.contains()

b521ae6

Fix crash in `hasTrailingWhitespace()` when trailing character is Emoji.

kutschenator mentioned this pull request Nov 24, 2016

Add rule prefer () -> over Void -> #573

Closed

jpsim added 5 commits December 1, 2016 00:34

make lots of Swift 3 related changes

39e1001

many of which are to help with otherwise very long compile times

remove unnecessary swiftlint:disable command

c305f2b

update excluded directory in .swiftlint.yml

7075def

Merge pull request #915 from realm/jp-swift3-suggestions

2871868

make lots of Swift 3 related changes

Merge branch 'master' into swift3.0

e3ed767

norio-nomura added 2 commits December 2, 2016 10:01

Fix crash in ReporterTests.testHTMLReporter() on swift test

f8beeb7

Disable few tests related to docs

4072bd4

jpsim/SourceKitten#269

change Array.arrayOf(_:) to Array.array(of:)

0b481f1

Merge pull request #919 from realm/jp-swift-3-array-of

25f41e8

change Array.arrayOf(_:) to Array.array(of:)

add changelog entry about move to Swift 3

a163811

jpsim approved these changes Dec 2, 2016

View reviewed changes

norio-nomura commented Dec 2, 2016

View reviewed changes

s/SourceKitten/SwiftLint/

a4cef39

Add credit

aff5c7f

jpsim merged commit 64f67cc into master Dec 2, 2016

norio-nomura deleted the swift3.0 branch December 2, 2016 07:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Swift 3.0 #832

Migrate to Swift 3.0 #832

norio-nomura commented Oct 8, 2016

norio-nomura commented Oct 14, 2016

norio-nomura commented Nov 4, 2016

jpsim commented Nov 25, 2016

jpsim commented Dec 1, 2016

norio-nomura commented Dec 1, 2016

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

jpsim left a comment

norio-nomura Dec 2, 2016

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

codecov-io commented Dec 2, 2016

norio-nomura commented Dec 2, 2016 •

edited

Loading

jpsim commented Dec 2, 2016

Migrate to Swift 3.0 #832

Migrate to Swift 3.0 #832

Conversation

norio-nomura commented Oct 8, 2016

norio-nomura commented Oct 14, 2016

norio-nomura commented Nov 4, 2016

jpsim commented Nov 25, 2016

jpsim commented Dec 1, 2016

norio-nomura commented Dec 1, 2016

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

jpsim left a comment

Choose a reason for hiding this comment

norio-nomura Dec 2, 2016

Choose a reason for hiding this comment

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

norio-nomura commented Dec 2, 2016

codecov-io commented Dec 2, 2016

Current coverage is 83.86% (diff: 80.53%)

norio-nomura commented Dec 2, 2016 • edited Loading

jpsim commented Dec 2, 2016

norio-nomura commented Dec 2, 2016 •

edited

Loading