Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidDocs rule #420

Merged
merged 3 commits into from
Jan 26, 2016
Merged

Fix ValidDocs rule #420

merged 3 commits into from
Jan 26, 2016

Conversation

diogoguimaraes
Copy link
Contributor

Closes #375 .

@diogoguimaraes diogoguimaraes self-assigned this Jan 26, 2016
@diogoguimaraes
Copy link
Contributor Author

@jpsim can you help me with the codecov please?

@jpsim
Copy link
Collaborator

jpsim commented Jan 26, 2016

Thanks for this! The code coverage isn't significantly affected so that's fine, but this code is kind of duplicated at this point, so it'd be good to combine, which would also incidentally help code coverage.

Nice work!

@diogoguimaraes
Copy link
Contributor Author

Thanks!
Do you think we should do this before merging this PR?
Regarding the "combine" could you be more specific?

@jpsim
Copy link
Collaborator

jpsim commented Jan 26, 2016

I made a few minor changes: combining some duplicate code and adding a changelog entry. This will be good to go once it passes CI.

Thanks again!

jpsim added a commit that referenced this pull request Jan 26, 2016
@jpsim jpsim merged commit c888215 into master Jan 26, 2016
@jpsim jpsim deleted the bugfix/valid-docs-rule branch January 26, 2016 18:07
@diogoguimaraes
Copy link
Contributor Author

Thanks again!
Do you have an ETA to the next release?

@jpsim
Copy link
Collaborator

jpsim commented Jan 26, 2016

0.7.0 was accepted into Homebrew yesterday: Homebrew/legacy-homebrew#48425 (comment)

Do you need the fix from this PR in a release? If so, I could push out a 0.7.1 release today, although I can't say when Homebrew will accept it. The last few submissions each took a few days.

@diogoguimaraes
Copy link
Contributor Author

That would be great! Thank you.

@jpsim
Copy link
Collaborator

jpsim commented Jan 26, 2016

0.7.1 has been cut: https://github.com/realm/SwiftLint/releases/tag/0.7.1

and submitted to homebrew: Homebrew/legacy-homebrew#48497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants