-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ValidDocs rule #420
Fix ValidDocs rule #420
Conversation
@jpsim can you help me with the |
Thanks for this! The code coverage isn't significantly affected so that's fine, but this code is kind of duplicated at this point, so it'd be good to combine, which would also incidentally help code coverage. Nice work! |
Thanks! |
I made a few minor changes: combining some duplicate code and adding a changelog entry. This will be good to go once it passes CI. Thanks again! |
Thanks again! |
0.7.0 was accepted into Homebrew yesterday: Homebrew/legacy-homebrew#48425 (comment) Do you need the fix from this PR in a release? If so, I could push out a 0.7.1 release today, although I can't say when Homebrew will accept it. The last few submissions each took a few days. |
That would be great! Thank you. |
0.7.1 has been cut: https://github.com/realm/SwiftLint/releases/tag/0.7.1 and submitted to homebrew: Homebrew/legacy-homebrew#48497 |
Closes #375 .