New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid docs rule not covering all closure parameter cases. #375

Closed

diogoguimaraes opened this issue Jan 15, 2016 · 1 comment

Labels

bug

Contributor

diogoguimaraes commented Jan 15, 2016

I've noticed that some cases are not being covered by the validDocsRule and SwiftLint generates wrong warnings, for instance:

func foobar (closure1: () -> Foo, closure2: (foobar: Bar) -> Foo, closure3: (foobar: Bar) -> Foo) {
func footer (closure1: (Foo) -> Void, onError closure2: ((NSError) -> Void)? = nil) {

I'll add a pull request with a fix for this ASAP.

The text was updated successfully, but these errors were encountered:

Collaborator

jpsim commented Jan 15, 2016

I'll add a pull request with a fix for this ASAP.

Thanks!

jpsim added the bug label

diogoguimaraes mentioned this issue

Fix ValidDocs rule #420

Merged

jpsim closed this as completed in #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment