Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Navbar): Added dark prop #567

Closed
wants to merge 1 commit into from

Conversation

Lobosque
Copy link

@Lobosque Lobosque commented Sep 9, 2017

If there is a light prop to add the navbar-light class, then to keep consistency there should also be a dark prop to add the navbar-dark class.
This PR adds the dark prop which will add the aforementioned class when set. With a test and the prop entry in the comments.

@TheSharpieOne
Copy link
Member

TheSharpieOne commented Sep 9, 2017

This is already addressed in the v5 branch which accounts for changes in bootstrap 4 beta. A release will be published as soon as it is ready, we are waiting on a few more changes/fixes.
See #487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants