-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Beta 1 Changes #487
Comments
Renamed .card-block to .card-body https://github.com/twbs/bootstrap/pull/22828 |
For the changes where this makes sense, such as |
Popovers look like they have changed quite a bit. The arrow is no longer hard-coded to the middle of the popover, it is more dynamic to be center-aligned with the item it is relative to thanks to poppers.js. |
Interesting. Since tether is the biggest pain right now, I'll prioritize popper + popper related component updates so we get that tested sooner. It could be worth getting that into the alpha 6 version first. I'll explore and post updates in a WIP branch. |
A couple
|
#535 suggests the default color for |
Current dropdowns do not work with Beta, now need a |
Ugg.., the form feedback classes have been changed: https://getbootstrap.com/docs/4.0/components/forms/#server-side So the FormGroup and FormFeedback components no longer work. |
any update on when this lib will be updated to the beta version? |
As I make some of the changes in the list and look for additional changes for the components I am noticing the utilities are used a ton. I wonder how much we can bake into each component and how much we just depend on the user to add |
Thanks for helping with this @TheSharpieOne . I'll help with any additional PRs for any remaining work this weekend to hopefully get V5 pushed. |
Is it really that hard to write out all of your divs with proper bootstrap classes? May as well go all the way. |
@TheSharpieOne I think using classNames is just fine. It's even easier for people like me that use both Bootstrap for projects without react and reactstrap. |
Looking at popper.js and react-popper, I think we might have to make our own little react wrapper for popper.js instead of using react-popper. The reason is mostly because of the wrapping component which is nice when using react-popper, but it would force reactstrap users to wrap their components in a similar fashion. |
I created a popper branch with my experimental attempt at implementing popperjs via react-popper. Tooltips and Popovers look good. Having some difficulty with Dropdown since react-popper's manager add a wrapping element which is messing up the |
I am leaving the offsets alone (and marking them as completed) since they have been added back to bootstrap: twbs/bootstrap#23445 |
Could you guys post it to npm, so other can start building on this branch? I've started updating from react-bootstrap (v4) to your library but would like to start building with beta bootstrap |
If anyone need to use current state of reactstrap for bootstrap4-beta, I posted an npm package:
If you use webpack, just add this to your config until we can use master version of this package.
|
@bartoszhernas thanks for creating! For those waiting on the Carousel, it's included in this package. I successfully implemented it using this as a guide: https://github.com/reactstrap/reactstrap/blob/v5/docs/lib/examples/Carousel.js |
Is anyone working on updating form classes for validation? |
Its a few lines of code ... already done in extending projects ... the problem now is merging ... so we actually need to get the Popover and RTG 2.0 stuff merged then we can rebase and do the work on the form validation. |
Any chance we could tag the v5 branch with a beta tag for people to test with? |
@th3fallen
|
[email protected] has been published to npm using the |
@TheSharpieOne You guys are amazing! The dropdown just works now! |
read through twbs/bootstrap#21568
.card-block
to.card-body
Rename .card-block to .card-body twbs/bootstrap#22828inverse
is no longer a thing, just use.text-white
(keep for convenience?).card-outeline-{color}
) is now border util.border-{color}
.card-{color}
) is now bg util.bg-{color}
.nav-fill
vertical
should accept a string for the responsive size (.flex-{size}-column
).card-header-tabs
/.card-header-pills
(add booleancard
prop?).navbar-inverse
->.navbar-dark
.navbar-toggler-left
and.navbar-toggler-right
have been removedNavbar
toggle class.navbar-toggleable{-sm|-md|-lg|-xl}
->.navbar-expand{-sm|-md|-lg|-xl}
.popover-title
to.popover-header
and.popover-content
to.popover-body
Rename popover classes twbs/bootstrap#22829.show
is now needed on.dropdown-menu
when open.badge-default
->.badge-secondary
bootstrap v4 beta docs: https://getbootstrap.com/docs/4.0/getting-started/introduction/
The v5 branch will have the latest changes while the list is being completed. Items marked as completed on the list indicate that the item is addressed in the v5 branch. This issue will be closed one v5 has been merged into master.
Feel free to add anything not listed with a general description and link to either docs page or pr and I'll update the list 🙌
The text was updated successfully, but these errors were encountered: