-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Features/vite plays outside updated json/578 #1253
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for reactplayio failed.
|
Hi @Angra974 I want an update on this. need to plan further things accordingly |
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP : This is not made in the intend to be merged but a showcase
Description
if image is generated and information is present in index.json file
else
else
- else
plays can be inside src/plays folder or be in another folder
package.json file contains only modules needed for the main app to run.
developer need to add package with the "-w" tag to be use in the workspace
each play has it own package.json file. This package.json file is created by create-react-play #43
=> developer need to add package in their play when they create the play by using
"pnpm add my_package"
Typescript version is set
Eslint give no error for configuration
Only allow pnpm - no other builder will be used in this app
husky prepush with cypress test
=> push are done only if test doesn't fail
=> test was rewritten to pass the current build
index.json file
=> create by create-react-play [✨ [Feature request]: Show no play found when there is no match for filter and search result #43]
=> contains the minium information needed to run react-play and plays
=> a relative path to the play folder. Need for import with vitejs as relative path to file.
=> contains play slug name and play name so it's easy to recreate the path to the file
=> used to load all plays in playlist.jsx as a filter to the request but load only the required information and not all the plays are imported as it's actually done.
=> use as a filter in playMeta.jsx to import only one play in the require page and not all plays as it's actually done
=> use to handle navigation between play in the individual play page. So, developer can have a previous and next button to click to test if their modification affect other play or not. I use it to test which play needed a personnal package or not when created individual package.json file
github workflow rewritten to use pnpm
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This is not intended to be merged but to show how index.json file can be use for improving the performance of the application and code organisation for using plays outiside the main application and vite.
Fixes #1251
Fixes #1229
Fixes #1243
Fixes #1239
Fixes #1217
Fixes #1212
Fixes #1193
Fixes #1189
Fixes #1100
Fixes #866
Know issues
Didn't test play created by the developer and how to handle it in playList.js has it was not my intention to do it.
The playList.jsx was recoded only to be able do display the content from index.json so not all functionnalities in playList.jsx was recreated and handled correctly. Will need more attention later.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test was done with vitest for component test
Tests was done with cypress for e2e and pages load
All pages was tested
All plays were controlled individually and rewritten when necessary and minimal package installed to get them running well.
prepush and test before prepush was tested when making this request
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Screenshots or example output