Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some errors happen when installation is done with a new package.json file ( dependencies version are not the same as the current reactplay ) #1239

Closed
Angra974 opened this issue Sep 9, 2023 · 1 comment · Fixed by #1337
Assignees

Comments

@Angra974
Copy link
Contributor

Angra974 commented Sep 9, 2023

When updating my dependencies ( eslint got problem currently in react-play when you use it with pnpm )
we got some errors :

image
Solution :
Comment this line in the file


image
Solution:
Delete current in the import


image
Solution:
delete the "event" variable in the onClick call.


image
Solution:
delete the "event" variable in the onClick call


image
Solution:
delete the "event" variable in the onClick calls


image
Solution:
Delete "plural" in the import
Delete "resp" as a parameter in then()


image
Solution:
Delete the import for playHeader
Delete the props in the function component


image
Solution:
Comment "const [error, setError] = useState('');"
Comment setError to console.log at line 45


image
Solution:
Comment "const data = structuringData[currState];"


image
Solution:
Don't import the useState at line 1


image
Solution:
Don't assign the fetch to the const "promise"
Don't assign the response result to the const "data"


image
Solution:
Comment line 3 where the import is done


image
Solution:
1- create a useState for "count" instead declaring it with let.
2 - make it works ( trick the code )


image
Solution:
Don't use "e" in the HandleCardColor as it not called inside the function


image
Solution:
Don't use event in the clickHandler function


image
Solution:
use the variable "err" as a parameter of setError


image
Solution:
Comment the line import for "data"

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment