Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building Your Own Hooks page translation #78

Merged
merged 9 commits into from
Feb 11, 2019
Merged

Building Your Own Hooks page translation #78

merged 9 commits into from
Feb 11, 2019

Conversation

WendellAdriel
Copy link
Member

#1

@tesseralis tesseralis mentioned this pull request Feb 11, 2019
Closed
90 tasks
@WendellAdriel WendellAdriel added the needs review A pull request ready to be reviewed label Feb 11, 2019
eshinkawa
eshinkawa previously approved these changes Feb 11, 2019
View reviewed changes
Copy link

@eshinkawa eshinkawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation is fine.

gabrielbs
gabrielbs reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@gabrielbs gabrielbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct, congratulations =)

@WendellAdriel
Copy link
Member Author

Thank you so much @eshinkawa and @gabrielbs.
cc: @glaucia86, @cezaraugusto, @fjoshuajr.

fjoshuajr
fjoshuajr approved these changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei alguns comentários.

content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
fjoshuajr
fjoshuajr requested changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei alguns comentarios.

@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 11, 2019
@fjoshuajr @WendellAdriel
Improve translation
c893f45 
Co-Authored-By: WendellAdriel <[email protected]>
fjoshuajr and others added 6 commits February 11, 2019 21:17
@fjoshuajr @WendellAdriel
Improve translation
c44c033 
Co-Authored-By: WendellAdriel <[email protected]>
@fjoshuajr @WendellAdriel
Improve translation
4bafd5b 
Co-Authored-By: WendellAdriel <[email protected]>
@fjoshuajr @WendellAdriel
Improve translation
25c3b02 
Co-Authored-By: WendellAdriel <[email protected]>
@fjoshuajr @WendellAdriel
Improve translation
0bae689 
Co-Authored-By: WendellAdriel <[email protected]>
@fjoshuajr @WendellAdriel
Improve translation
2c4c619 
Co-Authored-By: WendellAdriel <[email protected]>
@fjoshuajr @WendellAdriel
Improve translation
f27c54f 
Co-Authored-By: WendellAdriel <[email protected]>
@WendellAdriel
Copy link
Member Author

Thank you so much @fjoshuajr!!!
All done!!! 😉

@WendellAdriel WendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
@fjoshuajr @WendellAdriel
Improve translation
795a1b6 
Co-Authored-By: WendellAdriel <[email protected]>
@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 11, 2019
@fjoshuajr
Copy link
Collaborator

Como este PR teve mais de um reviewer, vou fazer merge direto. 🚀

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 11, 2019
@fjoshuajr fjoshuajr merged commit 8ced6ea into reactjs:master Feb 11, 2019
@halian-vilela halian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielbs gabrielbs gabrielbs left review comments

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@eshinkawa eshinkawa eshinkawa left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WendellAdriel @fjoshuajr @gabrielbs @eshinkawa