Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translates Invalid hook call warning #52

Merged
merged 8 commits into from
Feb 14, 2019
Merged

Translates Invalid hook call warning #52

merged 8 commits into from
Feb 14, 2019

Conversation

henriquejensen
Copy link
Contributor

No description provided.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
jhonmike
jhonmike previously approved these changes Feb 10, 2019
View reviewed changes
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquejensen
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@glaucia86
Copy link
Member

@henriquejensen
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@henriquejensen
Copy link
Contributor Author

@glaucia86 acabei fazendo um merge com a master antes das alterações, não sei se foi o correto, qualquer coisa eu repito o pull request

@eduardomoroni eduardomoroni added needs +1 Needs another approval before merging feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed feedback addressed needs +1 Needs another approval before merging labels Feb 12, 2019
@fjoshuajr
Copy link
Collaborator

@henriquejensen volte a fazer um novo PR 😉, esse tem muitos ficheiros.

@fjoshuajr fjoshuajr added the invalid Something that is outside the scope label Feb 12, 2019
@cezaraugusto cezaraugusto force-pushed the invalid-hook-call-warning branch from 780d987 to 38af765 Compare February 13, 2019 04:26
@cezaraugusto
Copy link
Member

@henriquejensen obrigado por tirar um tempinho pra fazer essas alteracoes! fiz um rebase do seu branch pra ajudar os revisores.

@fjoshuajr pode conferir de novo? vou remover a tag invalid

@cezaraugusto cezaraugusto added feedback addressed and removed invalid Something that is outside the scope needs author response Changes requested needing author's input labels Feb 13, 2019
fjoshuajr
fjoshuajr requested changes Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquejensen estamos quase lá 💪

content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 13, 2019
@henriquejensen
Copy link
Contributor Author

Hey @fjoshuajr acabei de realizar o commit com as alterações que voce solicitou

fjoshuajr
fjoshuajr approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉✨

@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 14, 2019
@glaucia86 glaucia86 merged commit cd23555 into reactjs:master Feb 14, 2019
@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

@jhonmike jhonmike jhonmike left review comments

Assignees

@glaucia86 glaucia86

@fjoshuajr fjoshuajr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@henriquejensen @glaucia86 @fjoshuajr @cezaraugusto @jhonmike @eduardomoroni