-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate state and lifecycle page #39
Conversation
@tibuurcio what do you think about using |
@cezaraugusto I personally think leaving just Maybe I'm just used to see it being written as |
Also I was thinking, I think it could be |
I think that state can represent two different things and should be treated acordingly... When representing the current state of the application, as a snapshot in time, I don't think it loses semantic value if we translate it to "estado". I guess it only loses value when it's talking about Makes sense? |
@halian-vilela It makes sense, indeed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Só mudar essa última coisinhas sobre o gênero das funções.
Co-Authored-By: jhonmike <[email protected]>
Co-Authored-By: jhonmike <[email protected]>
Esse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obrigado @jhonmike! pedi uns ajustes: um erro de ortografia e para capitalizar as palavras dos títulos, como original. De resto tá ótimo pra mim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!
WendellAdriel e eu já realizamos o review desse PR e as alterações solicitadas já foram feitas.
#1
Sections: