Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate React API Reference #31

Merged
merged 25 commits into from
Feb 10, 2019
Merged

Translate React API Reference #31

merged 25 commits into from
Feb 10, 2019

Conversation

renato-bohler
Copy link
Contributor

No description provided.

@eduardomoroni eduardomoroni added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome translation @renato-bohler! I guess this is the biggest one so far.

I've left some comments with improvements I saw to make reading easier for PT-Br readers. They're not set in stone and up for debate if you like. Thanks for taking time to do this all!

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@renato-bohler
Copy link
Contributor Author

Hey @cezaraugusto I've just revised every change request you've made and I agree with most of it.

I've left some comments on the others.

As soon as we resolve all of these, I'll adjust everything and give it another read just to make sure.

Thanks 😄

@cezaraugusto
Copy link
Member

thanks @renato-bohler! agree with your comments.

btw for things we agreed at first there's a button where you can apply changes without manually editing them, but I guess you know that already

@renato-bohler
Copy link
Contributor Author

Nice! I'm committing those now then.

cezaraugusto and others added 17 commits February 9, 2019 19:56
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
afc7a30 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
c2a1ed6 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
b60f5ed 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
9afed59 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
1ba1d19 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
0753ab6 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
c99afea 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
f413ef6 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
8478054 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
b7db89f 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
5115ad6 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
4635577 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
15681a1 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
40937cf 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
748bda0 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
32fd079 
Co-Authored-By: renato-bohler <[email protected]>
@cezaraugusto @renato-bohler
Update content/docs/reference-react.md
940b54d 
Co-Authored-By: renato-bohler <[email protected]>
@renato-bohler renato-bohler changed the title translate React API Reference Translate React API Reference Feb 9, 2019
@renato-bohler
Copy link
Contributor Author

Done. There's only one still unresolved that I've decided to change a little bit.

@glaucia86
Copy link
Member

@renato-bohler

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@renato-bohler
Copy link
Contributor Author

@glaucia86 resolvi todas, mas aparentemente não consigo trocar o label do PR.

@eduardomoroni eduardomoroni added needs review A pull request ready to be reviewed and removed needs author response Changes requested needing author's input labels Feb 10, 2019
@eduardomoroni
Copy link
Member

Qual label seria o correto para o caso em que o autor fez as mudanças requeridas pelos revisores?

@glaucia86
Copy link
Member

Qual label seria o correto para o caso em que o autor fez as mudanças requeridas pelos revisores?

a Laranja. Criei para nos sinalizar de que vocês já efetuaram as mudanças necessárias e voltar para essa task e aprovar as contribuições.

cezaraugusto
cezaraugusto approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed feedback addressed needs review A pull request ready to be reviewed labels Feb 10, 2019
glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renato-bohler
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit 1ad8a0b into reactjs:master Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 10, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@cezaraugusto
Copy link
Member

@eduardomoroni geralmente eu removo o "needs author response" e adiciono de volta o "needs review". A etiqueta que a @glaucia86 criou é boa também

@renato-bohler
Copy link
Contributor Author

Massa! Se precisarem de mais alguma tradução ou de um review, só dar um grito!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renato-bohler @cezaraugusto @glaucia86 @eduardomoroni @fjoshuajr