Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate SyntheticEvent #22

Merged
merged 14 commits into from
Feb 11, 2019
Merged

Translate SyntheticEvent #22

merged 14 commits into from
Feb 11, 2019

Conversation

cezaraugusto
Copy link
Member

No description provided.

@cezaraugusto cezaraugusto added the needs review A pull request ready to be reviewed label Feb 9, 2019
@cezaraugusto cezaraugusto self-assigned this Feb 9, 2019
glaucia86
glaucia86 previously approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 9, 2019
@cezaraugusto cezaraugusto removed their assignment Feb 9, 2019
halian-vilela
halian-vilela requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótima tradução! Inseri só alguns ajustes para deixar algumas áreas mais simples/claras.

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Show resolved Hide resolved
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 9, 2019
@cezaraugusto cezaraugusto added needs review A pull request ready to be reviewed and removed needs author response Changes requested needing author's input labels Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
ericp3reira
ericp3reira suggested changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@ericp3reira ericp3reira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @cezaraugusto! I've left some suggestions and correct some typos. Can you take a look? 😄

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
halian-vilela
halian-vilela previously approved these changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Valeu!

glaucia86
glaucia86 previously approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ericp3reira Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 10, 2019
@glaucia86 glaucia86 removed feedback addressed needs review A pull request ready to be reviewed labels Feb 10, 2019
@cezaraugusto cezaraugusto dismissed stale reviews from glaucia86 and halian-vilela via b980b37 February 11, 2019 01:07
@cezaraugusto
Copy link
Member Author

@ericp3reira obrigado pela revisão
@halian-vilela @glaucia86 como vocês aprovaram antes e as alterações do @ericp3reira foram aplicadas estou fazendo o merge agora. obrigado!

@cezaraugusto cezaraugusto merged commit b661219 into master Feb 11, 2019
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 11, 2019
@fjoshuajr fjoshuajr added the 🌐 translated Translation is completed for this page label Feb 11, 2019
@fjoshuajr fjoshuajr changed the title translate SyntheticEvent Translate SyntheticEvent Feb 11, 2019
@jcserracampos jcserracampos deleted the syntheticEvents branch July 26, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericp3reira ericp3reira ericp3reira requested changes

@glaucia86 glaucia86 glaucia86 left review comments

@halian-vilela halian-vilela halian-vilela left review comments

@gmsecrieru gmsecrieru Awaiting requested review from gmsecrieru

@eduardomoroni eduardomoroni Awaiting requested review from eduardomoroni

@WendellAdriel WendellAdriel Awaiting requested review from WendellAdriel

@fjoshuajr fjoshuajr Awaiting requested review from fjoshuajr

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cezaraugusto @halian-vilela @glaucia86 @ericp3reira @eduardomoroni @fjoshuajr