Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Typechecking with Proptypes page #17

Merged
merged 8 commits into from
Feb 10, 2019
Merged

Translate Typechecking with Proptypes page #17

merged 8 commits into from
Feb 10, 2019

Conversation

lucasdeassis
Copy link
Contributor

#1

@lucasdeassis lucasdeassis changed the title translate typechecking with proptypes page Translate Typechecking with Proptypes page Feb 8, 2019
klzns
klzns suggested changes Feb 8, 2019
View reviewed changes
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 8, 2019
glaucia86
glaucia86 requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasdeassis algumas alterações a serem feitas.
Quando terminar colocar como 'Resolve Conversation' que analisaremos novamente as alterações e logo aprovação da sua contribuição. Muito obrigada.

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 previously approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cezaraugusto @fjoshuajr could you please see if it's okay?

@glaucia86 glaucia86 added needs resolution Something not defined that needs maintainers input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 9, 2019
cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lucasdeassis looks good overall. left some comments

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging needs resolution Something not defined that needs maintainers input labels Feb 9, 2019
cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @lucasdeassis!

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
halian-vilela
halian-vilela requested changes Feb 9, 2019
View reviewed changes
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated

You can define default values for your `props` by assigning to the special `defaultProps` property:
Você pode definir valores default para suas `props` através da atribuição à propriedade especial `defaultProps`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Você pode definir valores default para suas `props` através da atribuição à propriedade especial `defaultProps`:
Você pode definir valores default para suas `props` atribuindo-os à propriedade especial `defaultProps`:

A little bit more concise.

content/docs/typechecking-with-proptypes.md Outdated

As your app grows, you can catch a lot of bugs with typechecking. For some applications, you can use JavaScript extensions like [Flow](https://flow.org/) or [TypeScript](https://www.typescriptlang.org/) to typecheck your whole application. But even if you don't use those, React has some built-in typechecking abilities. To run typechecking on the props for a component, you can assign the special `propTypes` property:
Na medida em que sua aplicação cresce, você pode capturar muitos bugs com checagem de tipos. Em algumas aplicações, você pode usar extensões do JavaScript como [Flow](https://flowtype.org/) ou [TypeScript](https://www.typescriptlang.org/) para checar os tipos de toda a sua aplicação. Porém, mesmo se você não usá-las, React possui algumas habilidades de checagem de tipos embutidas. Para executar a checagem de tipos nas props para um componente, você pode atribuir à propriedade em especial `propTypes`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Na medida em que sua aplicação cresce, você pode capturar muitos bugs com checagem de tipos. Em algumas aplicações, você pode usar extensões do JavaScript como [Flow](https://flowtype.org/) ou [TypeScript](https://www.typescriptlang.org/) para checar os tipos de toda a sua aplicação. Porém, mesmo se você não usá-las, React possui algumas habilidades de checagem de tipos embutidas. Para executar a checagem de tipos nas props para um componente, você pode atribuir à propriedade em especial `propTypes`:
Na medida em que sua aplicação cresce, você pode capturar muitos bugs com checagem de tipos. Em algumas aplicações, você pode usar extensões do JavaScript como [Flow](https://flowtype.org/) ou [TypeScript](https://www.typescriptlang.org/) para checar os tipos de toda a sua aplicação. Porém, mesmo se você não usá-las, React possui algumas habilidades de checagem de tipos embutidas. Para executar a checagem de tipos nas props para um componente, você pode atribuir a propriedade especial `propTypes`:

Copy link
Contributor Author

@lucasdeassis lucasdeassis Feb 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the verb atribuir asks for a complement (bitransitivo). Then, if we have atribuir we need a target "object". That's why I added the "crase" to it (artigo + preposição).

In em especial, I understood that special propTypes property meant a particular property, more towards to the match of very one translation than to the word special one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but is really a trick thing. Let me know if you have another POV

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
fjoshuajr
fjoshuajr requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 10, 2019
fjoshuajr
fjoshuajr approved these changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

Looking good! 🎉

@fjoshuajr
Copy link
Collaborator

LGTM thanks @lucasdeassis!

I'll merge this then.

@fjoshuajr fjoshuajr merged commit d47a0b5 into reactjs:master Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halian-vilela halian-vilela halian-vilela requested changes

@klzns klzns klzns requested changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@cezaraugusto cezaraugusto cezaraugusto left review comments

@glaucia86 glaucia86 glaucia86 left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lucasdeassis @fjoshuajr @klzns @halian-vilela @glaucia86 @cezaraugusto @lucasassisrosa