Translating reference-react-component #130
Conversation
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Co-Authored-By: renato-bohler <[email protected]>
Alterando conforme sugerido pela @glaucia86 Co-Authored-By: rcantuario <[email protected]>
Alterando conforme sugerido pela @glaucia86 Co-Authored-By: rcantuario <[email protected]>
Co-Authored-By: rcantuario <[email protected]>
Alterando conforme sugerido pela @glaucia86 Co-Authored-By: rcantuario <[email protected]>
|
Adicionei a maioria das alterações sugeridas.. Aguardando a resposta sobre a tradução de mounting e unmounting |
There was a problem hiding this comment.
Pessoal, dei uma olhada por alto e LGTM!
Como @glaucia86 já olhou tb, creio que ajustando as dúvidas dos comentários já podemos aprovar!
Abraços
|
|
||
| - [`props`](#props) | ||
| - [`state`](#state) | ||
|
|
||
| * * * | ||
|
|
||
| ## Reference {#reference} | ||
| ## Referencia {#reference} |
There was a problem hiding this comment.
| ## Referencia {#reference} | |
| ## Referência {#reference} |
|
|
||
| Each component has several "lifecycle methods" that you can override to run code at particular times in the process. **You can use [this lifecycle diagram](http://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/) as a cheat sheet.** In the list below, commonly used lifecycle methods are marked as **bold**. The rest of them exist for relatively rare use cases. | ||
| #### Montando {#mounting} |
There was a problem hiding this comment.
@glaucia86 @rcantuario
Eu acho que seria o caso de deixar o original entre parênteses ,só para facilitar que o leitor faça a ligação com os nomes dos métodos de lifecycle.
| > | ||
| >- [`UNSAFE_componentWillUpdate()`](#unsafe_componentwillupdate) | ||
| >- [`UNSAFE_componentWillReceiveProps()`](#unsafe_componentwillreceiveprops) | ||
|
|
||
| #### Unmounting {#unmounting} | ||
| #### Desmontando {#unmounting} |
There was a problem hiding this comment.
Idem acima. Por mim, a gente colocava o original entre parênteses
|
|
||
| Each component has several "lifecycle methods" that you can override to run code at particular times in the process. **You can use [this lifecycle diagram](http://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/) as a cheat sheet.** In the list below, commonly used lifecycle methods are marked as **bold**. The rest of them exist for relatively rare use cases. | ||
| #### Montando {#mounting} |
There was a problem hiding this comment.
| #### Montando {#mounting} | |
| #### Montando (mounting) {#mounting} |
| > | ||
| >- [`UNSAFE_componentWillUpdate()`](#unsafe_componentwillupdate) | ||
| >- [`UNSAFE_componentWillReceiveProps()`](#unsafe_componentwillreceiveprops) | ||
|
|
||
| #### Unmounting {#unmounting} | ||
| #### Desmontando {#unmounting} |
There was a problem hiding this comment.
| #### Desmontando {#unmounting} | |
| #### Desmontando (unmounting) {#unmounting} |
eduardomoroni
removed
needs author response
Co-Authored-By: rcantuario <[email protected]>
Co-Authored-By: rcantuario <[email protected]>
Co-Authored-By: rcantuario <[email protected]>
|
@rcantuario inclua as setas que o @jhonmike bem sinalizou que estarei aprovando e mergeando a sua contribuição! Muito obrigada :) |
glaucia86
added
needs author response
|
@jhonmike assim que o @rcantuario fizer as alterações pode aprovar e mergear direto essa PR. ;) |
|
Acabei editando as sugestões do pessoal com as correções que encontrei, basta aceita-las @rcantuario |
|
@rcantuario precisa de ajuda nesse PR?! Só falta você para finalizarmos a tradução da documentação! |
|
Se ele estiver sem tempo, poderíamos mergear e abrir um issue para
finalizar esta página.
Em dom, 10 de mar de 2019 3:46 AM, Glaucia Lemos <[email protected]>
escreveu:
… ***@***.**** requested changes on this pull request.
@rcantuario <https://github.com/rcantuario> falta agora só você man!
Vamos! :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#130 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAyPbi2oirxVO_y1-Wr88dBSYurt8uXAks5vVHH9gaJpZM4bRpre>
.
|
|
Pessoal, o que está faltando é bem trivial, o restante já havia sido revisado, eu acho que já está em status de merge, só comittar as 3 alterações (mínimas) que eu sugeri aí... e mandar ver. |
|
Pessoal, tava conversando com o @jhonmike no Slack. O detalhe dessa PR é tão pequeno que não vale mantê-la aberta, vou mergear e abrir uma outra PR só para a pequena correção e a gente já finaliza Ok? |
No description provided.