Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate getting started #126

Merged
merged 7 commits into from
Mar 3, 2019
Merged

Translate getting started #126

merged 7 commits into from
Mar 3, 2019

Conversation

lucianomlima
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 24, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 6d97e6e

https://deploy-preview-126--pt-br-reactjs.netlify.com

@lucianomlima lucianomlima mentioned this pull request Feb 24, 2019
Closed
13 tasks
@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 25, 2019
glaucia86
glaucia86 requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucianomlima poucas mudanças a serem feitas. Basta dar uma olhada no que indiquei, alterá-las e nos enviar novamente.
Assim que nos enviar nos sinalize para que assim possamos o quanto antes aprovar a sua excelente contribuição. :)

cc: @cezaraugusto @halian-vilela @fjoshuajr Bastam dar uma olhada e fazer uma review! :)

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added the needs author response Changes requested needing author's input label Feb 25, 2019
@lucianomlima
Copy link
Contributor Author

Aguardando review e respostas das conversas

halian-vilela
halian-vilela requested changes Feb 25, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucianomlima

Cara, excelente tradução! Obrigado pela contribuição.

Fiz algumas considerações sobre algumas semânticas que achei que deixaria o texto mais preciso.

Dê uma olhada aí e estando tudo certo já estaremos prontos para fazer o merge!

Valeu!

content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@lucianomlima
Copy link
Contributor Author

@glaucia86 @halian-vilela Atualizado. Última rodada de dúvidas. Próximo push já vai ser o final.

glaucia86
glaucia86 previously approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucianomlima LGTM

Muito obrigada pela sua contribuição.

cc: @halian-vilela @cezaraugusto @fjoshuajr só aprovar essa PR ;)

content/docs/getting-started.md Show resolved Hide resolved
@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Feb 27, 2019
@jhonmike jhonmike mentioned this pull request Feb 28, 2019
Closed
90 tasks
jhonmike
jhonmike previously approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

frontendwizard
frontendwizard reviewed Mar 1, 2019
View reviewed changes
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@lucianomlima lucianomlima dismissed stale reviews from jhonmike and glaucia86 via bc899b7 March 3, 2019 03:49
@glaucia86 glaucia86 merged commit 8dc5f9d into reactjs:master Mar 3, 2019
@glaucia86
Copy link
Member

cc: @cezaraugusto e @halian-vilela aprovando direto essa PR ;)

@lucianomlima obrigada pela sua excelente contribuição.

LGTM 👍

Mergeando!

@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frontendwizard frontendwizard frontendwizard left review comments

@halian-vilela halian-vilela halian-vilela requested changes

@jhonmike jhonmike jhonmike left review comments

@glaucia86 glaucia86 glaucia86 left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucianomlima @glaucia86 @frontendwizard @halian-vilela @jhonmike