Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect Hook page #117

Merged
merged 10 commits into from
Mar 3, 2019
Merged

Effect Hook page #117

merged 10 commits into from
Mar 3, 2019

Conversation

WeslleyNasRocha
Copy link
Contributor

@WeslleyNasRocha WeslleyNasRocha commented Feb 20, 2019 •
edited
Loading

Coisas a fazer

  • Traduzir a parte principal do texto
  • Terminar tradução
  • Ajeitar pontuações
  • Traduzir menu lateral

@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 1ea799e

https://deploy-preview-117--pt-br-reactjs.netlify.com

@WeslleyNasRocha WeslleyNasRocha mentioned this pull request Feb 20, 2019
Closed
90 tasks
@WeslleyNasRocha WeslleyNasRocha changed the title [WIP] Effect Hook page Effect Hook page [minor wip] Feb 20, 2019
@halian-vilela halian-vilela added the work in progress Author opened the pull-request but it's still being worked on label Feb 21, 2019
@halian-vilela halian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
halian-vilela
halian-vilela requested changes Feb 21, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oi @WeslleyNasRocha

Obrigado pela tradução, adicionei algumas correções, principalmente de acentos e uma ou outra correção semântica para facilitar o entendimento.

Ainda não revisei 100% mas não vou ter tempo de continuar agora.

Mais no final da tarde eu adiciono o restante das considerações.

Até logo!

content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs author response Changes requested needing author's input needs +1 Needs another approval before merging labels Feb 21, 2019
@halian-vilela halian-vilela mentioned this pull request Feb 22, 2019
Closed
halian-vilela
halian-vilela requested changes Feb 23, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ufa! Pronto, @WeslleyNasRocha que página gigante hein!

Acho que agora consegui revisar tudo! Dá uma olhadinha aí e aplique as correções onde achar pertinente e logo aprovaremos sua contribuição.

Muito obrigado pelo esforço, esse não foi um texto fácil!

Pelo que vi, já tá tudo traduzido e esse seu item do check list que falta pode ser resolvido nas revisões, acha que podemos remover o label de WIP ?

Fico no aguardo!

Abraços!

content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 25, 2019
@WeslleyNasRocha WeslleyNasRocha changed the title Effect Hook page [minor wip] Effect Hook page Feb 25, 2019
@WeslleyNasRocha
Copy link
Contributor Author

Ufa! Pronto, @WeslleyNasRocha que página gigante hein!

Acho que agora consegui revisar tudo! Dá uma olhadinha aí e aplique as correções onde achar pertinente e logo aprovaremos sua contribuição.

Muito obrigado pelo esforço, esse não foi um texto fácil!

Pelo que vi, já tá tudo traduzido e esse seu item do check list que falta pode ser resolvido nas revisões, acha que podemos remover o label de WIP ?

Fico no aguardo!

Abraços!

É realmente foi um texto bem grandezinho, ja removi o wip do titulo e ja apliquei algumas correções que eu vi também.
Obrigado pelo tempo de revisar tudo 😄

@halian-vilela halian-vilela added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input work in progress Author opened the pull-request but it's still being worked on labels Feb 25, 2019
halian-vilela
halian-vilela previously approved these changes Feb 25, 2019
View reviewed changes
@halian-vilela
Copy link
Collaborator

Ufa! Pronto, @WeslleyNasRocha que página gigante hein!
Acho que agora consegui revisar tudo! Dá uma olhadinha aí e aplique as correções onde achar pertinente e logo aprovaremos sua contribuição.
Muito obrigado pelo esforço, esse não foi um texto fácil!
Pelo que vi, já tá tudo traduzido e esse seu item do check list que falta pode ser resolvido nas revisões, acha que podemos remover o label de WIP ?
Fico no aguardo!
Abraços!

É realmente foi um texto bem grandezinho, ja removi o wip do titulo e ja apliquei algumas correções que eu vi também.
Obrigado pelo tempo de revisar tudo 😄

Fantástico! @WeslleyNasRocha obrigado você pela tradução.

Vamos só esperar mais um revisor dar uma olhada e logo aceitaremos sua contribuição.

Abraços!

jhonmike
jhonmike previously approved these changes Feb 28, 2019
View reviewed changes
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
content/docs/hooks-effect.md Outdated Show resolved Hide resolved
@WeslleyNasRocha
Apply suggestions from code review
36b4262 
Co-Authored-By: WeslleyNasRocha <[email protected]>
@WeslleyNasRocha
Update content/docs/hooks-effect.md
1ea799e 
Co-Authored-By: WeslleyNasRocha <[email protected]>
@glaucia86
Copy link
Member

@halian-vilela aprovei confiando na sua revisão. Se puder aprovar e mergear.

cc: @WeslleyNasRocha muito obrigada pela sua excelente Contribuição. Da minha parte:

LGTM 👍

@jhonmike
Copy link
Member

jhonmike commented Mar 3, 2019

Parabéns pela contribuição, @WeslleyNasRocha! Vou efetuar o merge, pois, já temos duas aprovações :) 🚀

@jhonmike jhonmike merged commit a401fe7 into reactjs:master Mar 3, 2019
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging 💪 long page - more than 100 lines Long page labels Mar 3, 2019
@tibuurcio tibuurcio mentioned this pull request Mar 7, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

@halian-vilela halian-vilela halian-vilela left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WeslleyNasRocha @halian-vilela @glaucia86 @jhonmike