Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Forms page #100

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Translation of Forms page #100

merged 3 commits into from
Mar 7, 2019

Conversation

iagobruno
Copy link

#1

@cezaraugusto cezaraugusto added the needs review A pull request ready to be reviewed label Feb 16, 2019
@halian-vilela halian-vilela self-requested a review February 16, 2019 21:31
nsouzaco
nsouzaco reviewed Feb 16, 2019
View reviewed changes
content/docs/forms.md Outdated Show resolved Hide resolved
halian-vilela
halian-vilela requested changes Feb 16, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@httpiago

Boa noite! Adicionei algumas pequenas modificações.

Dê uma olhada nos exemplos de código pois, a princípio, eles não deveriam ser traduzidos.

Levantei essa questão junto à @cstpk para chegarmos em um consenso.

Fora isso, ótimo trabalho e obrigado pela contribuição! 😄

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 16, 2019
@tesseralis tesseralis mentioned this pull request Feb 18, 2019
Closed
90 tasks
@glaucia86
Copy link
Member

@httpiago tudo bem? Você precisa de ajuda para concluir essa PR? Se sim, por favor, não se hesite em nos sinalizar com

cc: @glaucia86 @halian-vilela

Para que tão logo possamos aprovar a sua excelente contribuição. Muito obrigada :)

@iagobruno
Copy link
Author

iagobruno commented Feb 25, 2019 •
edited
Loading

@glaucia86 Então, eu estava só esperando a resposta desse comentário pra saber se devo ou não reverter a tradução dos blocos de código.
Essas outras revisões aberta são basicamente a mesmo coisa.

glaucia86
glaucia86 requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@httpiago só faz a sugestão que eu sugeri q aprovarei em seguida a sua contribuição.

cc: @halian-vilela @eduardomoroni pelo que ficou acordado, strings em exemplos seriam traduzidas. Assim que, não vejo problemas em traduzir as strings de exemplos de código. O que vcs acham?

content/docs/forms.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added the needs resolution Something not defined that needs maintainers input label Mar 3, 2019
@iagobruno
Copy link
Author

iagobruno commented Mar 6, 2019 •
edited
Loading

Pronto @glaucia86 @halian-vilela, tudo resolvido, podem mesclar.

Vocês estão precisando de mais alguma ajuda?

@netlify
Copy link

netlify bot commented Mar 6, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit b8c0606

https://deploy-preview-100--pt-br-reactjs.netlify.com

@jhonmike jhonmike added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input needs resolution Something not defined that needs maintainers input labels Mar 6, 2019
glaucia86
glaucia86 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@httpiago Muito obrigada pela sua contribuição!

LGTM 👍

@glaucia86 glaucia86 merged commit 0bd5799 into reactjs:master Mar 7, 2019
@glaucia86 glaucia86 added the 🌐 translated Translation is completed for this page label Mar 7, 2019
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Mar 7, 2019
@micalevisk
Copy link

@httpiago Creio que em forms.md#tag-textarea-the-textarea-tag faltou envolver a primeira palavra "<textarea>" com backticks, pois, no momento, a página está assim:
https://pt-br.reactjs.org/docs/forms.html#the-textarea-tag

Além disso, os trechos de códigos nessa página não ficaram destacados (syntax highlight).

não consegui testar localmente.

@iagobruno iagobruno mentioned this pull request Mar 18, 2019
Merged
@iagobruno
Copy link
Author

Obrigado por avisar @micalevisk! Também não estou conseguindo iniciar o Gatsby localmente aqui por isso não vi o problema mas já enviei uma correção para a equipe do React Community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsouzaco nsouzaco nsouzaco left review comments

@halian-vilela halian-vilela halian-vilela requested changes

@jhonmike jhonmike jhonmike approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees

@halian-vilela halian-vilela

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iagobruno @glaucia86 @micalevisk @halian-vilela @jhonmike @nsouzaco @cezaraugusto