Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.7.0 #5712

Merged
merged 247 commits into from
Oct 14, 2019
Merged

Release v2.7.0 #5712

merged 247 commits into from
Oct 14, 2019

Conversation

willopez
Copy link
Member

@willopez willopez commented Oct 9, 2019

v2.7.0

Reaction v2.7.0 adds performance enhancements and fixes bugs.

This release is being coordinated with Reaction Platform and is designed to work with v2.7.0 of Reaction Hydra and Example Storefront.

Notable changes

More packages have continued to migrate from no-meteor folders to node-app

As part of de-meteorization of the Reaction API, We have continued the migration of moving all server side code in no-meteor folders to their respective node-app folders.

Potential Breaking Changes for Custom Plugins

There might be breaking changes in custom plugins due to the movement of core packages to the node-app folders. Custom plugins will need to update their imports paths to reflect the new location of packages.

Fixes

  • fix: pass correct userId when creating a shop (#5694)
  • fix: filter products by file on Windows (#5700)

Refactors

  • refactor: Move accounts plugin to Node app and better split accounts from users/IDP (#5693)
  • refactor: clean-up tasks related to removing appEvents from all meteor code (#5692)
  • refactor: clean-up tasks related to moving files to the node-app (#5688)
  • refactor: simpleSchema updates for mockContext (#5685)
  • refactor: move getPaymentMethodConfigByName to context (#5684)
  • refactor: create archiveProducts GQL mutation to replace meteor methods (#5680)
  • refactor: move jobs-queue from server/no-meteor to node-app (#5678)
  • refactor: move cart from server/no-meteor to node-app (#5675)
  • refactor: move checkout from server/no-meteor to node-app (#5674)
  • refactor: move core plugin to Node app (#5673)
  • refactor: move discounts plugins to Node app (#5672)
  • refactor: move marketplace to Node app (#5671)
  • refactor: move orders from server/no-meteor to node-app (#5670)
  • refactor: move catalog from server/no-meteor to node-app (#5658)
  • refactor: move navigation from server/no-meteor to node-app (#5656)
  • refactor: move email from server/no-meteor to node-app (#5655)
  • refactor: move i18n from server/no-meteor to node-app (#5654)
  • refactor: move product and product-variant from server/no-meteor to node-app (#5669)
  • refactor: move sitemap-generator from server/no-meteor to node-app (#5667)
  • refactor: move Tags from server/no-meteor to node-app (#5665)
  • refactor: move dashboard from server/no-meteor to node-app (#5663)
  • refactor: move product-admin plugin to Node app (#5659)
  • refactor: move notifications plugin to Node app (#5661)

aldeed and others added 30 commits September 12, 2019 10:32
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
… created in background

Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
willopez and others added 15 commits October 8, 2019 10:19
Signed-off-by: Eric Dobbertin <[email protected]>

Co-Authored-By: Erik Kieckhafer <[email protected]>
…windows

fix: filter products by file on Windows
and rename discountCodeId to discountId

Signed-off-by: Eric Dobbertin <[email protected]>
…UserOnShopCreate

fix: pass correct userId when creating a shop
Signed-off-by: Eric Dobbertin <[email protected]>
…vePackageToNodeApp-cleanupTasks-appEvents

chore: clean-up tasks related to removing `appEvents` from all meteor code
…ccounts-plugin

Move accounts plugin to Node app and better split accounts from users/IDP
…nvertCatalogMethodsToGQL

refactor: create `archiveProducts` GQL mutation to replace meteor methods
Signed-off-by: Will Lopez <[email protected]>
@kieckhafer
Copy link
Member

Looks good overall, still seeing the memory issue with tests here. @aldeed You mentioned something about disabling something in the tests for the time being, is that an option for this release? Or do we need to hold off for this to be fixed?

@aldeed
Copy link
Contributor

aldeed commented Oct 11, 2019

@kieckhafer I did that already in 0a132bd and it seemed to resolve the issue in your PR but maybe didn't actually work.

I don't have any other ideas at the moment, but I'll keep thinking about it.

@aldeed
Copy link
Contributor

aldeed commented Oct 11, 2019

Actually there is one thing. Pete suggested trying https://www.npmjs.com/package/why-is-node-running. You'd have to wire that up locally and run tests to see if it has any details.

@willopez
Copy link
Member Author

@kieckhafer @aldeed I re-ran the test and they all passed. Seems like it's a Circle CI environment issue.

Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kieckhafer kieckhafer merged commit 10ce7bb into master Oct 14, 2019
@kieckhafer kieckhafer deleted the release-v2.7.0 branch October 14, 2019 22:52
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants