Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move dashboard from server/no-meteor to node-app #5663

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

kieckhafer
Copy link
Member

Resolves #5662
Impact: minor
Type: refactor

As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective /imports/plugins/*/server/no-meteor/ folders into their new /node-app/{core-services|plugins}/* folder.

Updates also include future-proofing some existing code, including adding filetype extensions (and index.js to imports)

Breaking changes

Any custom plugins that import files directly from the dashboard package will need to be updated.

Testing

  1. Start the application and see that it works as it should.

@kieckhafer kieckhafer requested a review from aldeed October 3, 2019 20:42
@aldeed aldeed merged commit 57b2416 into develop Oct 3, 2019
@aldeed aldeed deleted the refactor-kieckhafer-movePackageToNodeApp-dashboard branch October 3, 2019 22:06
@willopez willopez mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants