Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(5226): use catalyst button for mediauploader #5563

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

machikoyasuda
Copy link
Contributor

Resolves #5526
Impact: minor
Type: fix|refactor

Issue

  • Use Catalyst button for the mediaUploader

Solution

  • MediaUploader is used in 2 places so far: Shop Logo, Product Images -

  • Product Images:

Screen Shot 2019-09-16 at 2 32 33 PM

Screen Shot 2019-09-16 at 2 32 27 PM

- Logo:

Screen Shot 2019-09-16 at 1 47 12 PM

Screen Shot 2019-09-16 at 2 39 20 PM

Breaking changes

none

Testing

  1. Test image upload for shop logo
  2. Test image upload for product images

@machikoyasuda machikoyasuda changed the base branch from master to develop September 16, 2019 21:40
Signed-off-by: Machiko Yasuda <[email protected]>
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works as it should!

@kieckhafer kieckhafer merged commit ee3451e into develop Sep 17, 2019
@kieckhafer kieckhafer deleted the 5526-dropzone-button branch September 17, 2019 22:49
@kieckhafer kieckhafer mentioned this pull request Sep 18, 2019
@kieckhafer kieckhafer mentioned this pull request Sep 25, 2019
@ghost
Copy link

ghost commented Aug 19, 2020

@machikoyasuda this appears to have regressed in recent versions of the api (such as 3.8.0). think you could take a look at the issues I linked and give us some insight into what might be wrong? thank you! 🙏

@kieckhafer
Copy link
Member

Hey @balibebas, starting with Reaction v3.0, the admin was moved into a standalone app. There is no longer any UI in this particular reaction project.

Is this an issue you are seeing with the standalone reaction-admin UI? If so, could you please create a ticket in that repository with your issue?

@ghost
Copy link

ghost commented Aug 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants